From 8137ec54ba8637e222fe7ff284d720f997eddd6a Mon Sep 17 00:00:00 2001 From: Vikrant Gupta Date: Sat, 26 Oct 2024 21:46:18 +0530 Subject: [PATCH] fix: arithmetic operators are removed from Dashboard query builder formulas (#6276) * fix: the redirect from dashboard landing page to edit removing arithmetic operations * fix: the url for the dashboard edit widget --- .../GridCardLayout/WidgetHeader/index.tsx | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/frontend/src/container/GridCardLayout/WidgetHeader/index.tsx b/frontend/src/container/GridCardLayout/WidgetHeader/index.tsx index 6d7839aa4f5..28d869de66f 100644 --- a/frontend/src/container/GridCardLayout/WidgetHeader/index.tsx +++ b/frontend/src/container/GridCardLayout/WidgetHeader/index.tsx @@ -18,6 +18,7 @@ import { QueryParams } from 'constants/query'; import { PANEL_TYPES } from 'constants/queryBuilder'; import useCreateAlerts from 'hooks/queryBuilder/useCreateAlerts'; import useComponentPermission from 'hooks/useComponentPermission'; +import useUrlQuery from 'hooks/useUrlQuery'; import history from 'lib/history'; import { RowData } from 'lib/query/createTableColumnsFromQuery'; import { isEmpty } from 'lodash-es'; @@ -72,16 +73,18 @@ function WidgetHeader({ tableProcessedDataRef, setSearchTerm, }: IWidgetHeaderProps): JSX.Element | null { + const urlQuery = useUrlQuery(); const onEditHandler = useCallback((): void => { const widgetId = widget.id; - history.push( - `${window.location.pathname}/new?widgetId=${widgetId}&graphType=${ - widget.panelTypes - }&${QueryParams.compositeQuery}=${encodeURIComponent( - JSON.stringify(widget.query), - )}`, + urlQuery.set(QueryParams.widgetId, widgetId); + urlQuery.set(QueryParams.graphType, widget.panelTypes); + urlQuery.set( + QueryParams.compositeQuery, + encodeURIComponent(JSON.stringify(widget.query)), ); - }, [widget.id, widget.panelTypes, widget.query]); + const generatedUrl = `${window.location.pathname}/new?${urlQuery}`; + history.push(generatedUrl); + }, [urlQuery, widget.id, widget.panelTypes, widget.query]); const onCreateAlertsHandler = useCreateAlerts(widget, 'dashboardView');