Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coordinator 및 View 관련 기본 구현 #11

Merged
merged 33 commits into from
Oct 30, 2020
Merged

Coordinator 및 View 관련 기본 구현 #11

merged 33 commits into from
Oct 30, 2020

Conversation

dev-Lena
Copy link
Contributor

@dev-Lena dev-Lena commented Oct 30, 2020 •
edited
Loading

Related Issues

Coordinator: #7 , #8
View: #6 , #9

Implement

Coordinator

  • 화면 전환을 담당하는 Coordinator
    • Coordinator, CoordinatorDelegate 프로토콜
    • AppCoordinator, MainCoordinator 클래스

View

  • SceneDelegate 및 Storyboard 삭제
  • View Controller 생산을 담당하는 AppViewControllersFactory
  • 코드로 layout 및 Constraint 설정을 위한 메소드를 갖고있는 LayoutGuideCompatible
  • Coordinator 화면 전환 확인을 위한 간단한 화면 구현
    • 로그인, 태그 카테고리, 태그 관리, 포토 노트 리스트

To Do

  • Coordinator 블로그 글 추가하기

dev-Lena added 30 commits October 23, 2020 14:38
@dev-Lena
feat: remove storyboard file base name from info.plist
aedff07 
#8
@dev-Lena
feat: remove storyboard name in Application Scene Manifest
9096989 
- from info.plist

#8
@dev-Lena
feat: remove Main.storyboard
58bd446 
#8
@dev-Lena
feat: set key window and root view controller in scene delegate
2d05123 
#8
@dev-Lena
feat: remove methods related UISceneSession lifecycle from app delegate
255da8b 
#8
@dev-Lena
feat: add UIWindow setting logic in app delegate
1869a8d 
#8
@dev-Lena
feat: delete SceneDelegate.swift file
09d2201
@dev-Lena
feat: delete Application Scene Manifest from Info.plist
d1db884 
#8
@dev-Lena
feat: implement Coordinator protocol to Coordinators
995bc66 
#8
@dev-Lena
chore: add swiftlint rule
ff326f0 
- disabled rules: trailing_whitespace
@dev-Lena
fix typo
b38dbbe
@dev-Lena
feat: implement Login Coordinator
e5f52c8 
#8
@dev-Lena
feat: basic implement Login ViewController for transitions
a8d045a 
#8
@dev-Lena
feat: set up first scene in AppDelegate
9f30c41 
- with NavigationController and LoginCoordinator

#8
@dev-Lena
refactor: rename LoginCoordinator to EntryCoordinator
1b9ad8d 
#8
@dev-Lena
refactor: rename loginContentView to contentView in LoginViewController
9dd3e36 
#8
@dev-Lena
refactor: integrate LoginDelegate and TagDelegate
0a6184c 
- eliminate LoginDelegate
- rename TagDelegate as TagSceneTransitioning

#8
@dev-Lena
feat: implement delegate methods of TagSceneTransitioning in EntryCoo…
683b448 
…rdinator

#8
@dev-Lena
refactor: rename TagSceneTransitioning to TagSceneTransitionDelegate
08327b8 
#8
@dev-Lena
feat: remove unnecessary Coordinator
aeb16d5 
- remove: EntryCoordinator class

#8
@dev-Lena
refactor: fix access modifier of protocol Coordinator
3658bbf 
- from public to internal

#8
@dev-Lena
feat: implement AppCoordinator
101003d 
#8
@dev-Lena
feat: add protocol CoordinatorDelegate to AppCoordinator
3a3afcc 
#8
@dev-Lena
feat: implement MainCoordinator
020729b 
- start: tagCategoryViewController

#8
@dev-Lena
feat: change delegate type in LoginViewController
7ac986d 
- to CoordinatorDelegate

#8
@dev-Lena
feat: implement LayoutGuideCompatible
b8badf1 
- make protocol
- object adopting this protocol: UILayoutGuide, UIView

#6
@dev-Lena
feat: add functions about center for LayoutGuideCompatible extension
992b11b 
- functions: to set constraints based on CenterX / CenterY

#6
@dev-Lena
feat: add functions about size for LayoutGuideCompatible extension
6650c47 
- functions: to set height / width

#6
@dev-Lena
chore: add images assets for signing in Apple and Google
5babec7 
#10
@dev-Lena
chore: add swiftLint rule
c67ac63 
- identifier_name
@dev-Lena dev-Lena added the ✨ feature new feature label Oct 30, 2020
@dev-Lena dev-Lena added this to the 코디네이터(Coordinator) milestone Oct 30, 2020
@dev-Lena dev-Lena self-assigned this Oct 30, 2020
@dev-Lena
Copy link
Contributor Author

구현을 위해 merge 후 진행하겠습니다.

@dev-Lena dev-Lena closed this Oct 30, 2020
@dev-Lena dev-Lena reopened this Oct 30, 2020
@dev-Lena dev-Lena merged commit 3cccc21 into dev Oct 30, 2020
@dev-Lena dev-Lena mentioned this pull request Oct 30, 2020
Closed
4 tasks
@dev-Lena dev-Lena added the 🎨 view draw user Interface label Oct 30, 2020
@dev-Lena dev-Lena deleted the feat/coordinator branch December 30, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dev-Lena dev-Lena

Labels
✨ feature new feature 🎨 view draw user Interface
Projects
None yet
Milestone
코디네이터(Coordinator)
Development

Successfully merging this pull request may close these issues.
1 participant
@dev-Lena