Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mer 2827 products assessment settings arent being honored in course setup #4542

Conversation

Francisco-Castro
Copy link
Contributor

@Francisco-Castro Francisco-Castro commented Jan 2, 2024

This PR fixed ticket MER-2827 where some values were not inherited after creating a section from a product.

In these lines some values were excluded such as max_attempts, retake_mode and so on. By doing that, those values were not passed to the created section.

@Francisco-Castro Francisco-Castro self-assigned this Jan 2, 2024
Copy link
Contributor

@darrensiegel darrensiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all look good, but we want to retarget this for a v0.26.1 HotFix. Please retarget this PR to the new hotfix-v0.26.1 branch

@Francisco-Castro Francisco-Castro changed the base branch from master to hotfix-v0.26.1 January 3, 2024 14:51
@Francisco-Castro Francisco-Castro force-pushed the MER-2827-products-assessment-settings-arent-being-honored-in-course-setup branch from 724cf5f to 1195d4f Compare January 3, 2024 15:01
@Francisco-Castro Francisco-Castro dismissed darrensiegel’s stale review January 3, 2024 15:03

Changed to target hotfix-v0.26.1

@darrensiegel darrensiegel merged commit 98c55cd into hotfix-v0.26.1 Jan 3, 2024
5 checks passed
@darrensiegel darrensiegel deleted the MER-2827-products-assessment-settings-arent-being-honored-in-course-setup branch January 3, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants