[BUG FIX] [MER-3553] Lesson end date formatting breaks ability to load Home screen #4992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgachuhi
approved these changes
Aug 1, 2024
rgachuhi
deleted the
MER-3553-Lesson-end-date-formatting-breaks-ability-to-load-Home-screen
branch
eliknebel
added a commit
that referenced
this pull request
Aug 15, 2024
* [BUG FIX] [MER-3423] Using keyboard shortcut (ctrl-del) to delete after a component has been copied causes issues (#4955) * MER-3423 * More changes * More Changes * trying to re-run checks * Update EditingCanvas.tsx * [MER-3393] Add grace period and fix some issues * [MER-3393] Changes from review * disable likert viz * async project export * do not include timestamp in filename to prevent unnecessary S3 usage * fix tests * fix cyclical dependency issue fix button padding * fix warnings * fix flaky test * dial up assert_receive time * add direct delivery research consent form setting * add research consent link, update form and logic to handle different scenarios * fix warnings * fix tests * flaky test * [BUG FIX] [MER-3010] fixes sparse likert and multiple attempts (#4966) Co-authored-by: Raphael Gachuhi <rgachuhi@cmu.edu> * [BUG FIX] [MER-3516] 500 error when-re-accessing a manually graded assessment (#4971) * handle attempt submitted state for manually graded activities * fix test * [BUG FIX] [MER-3506] After completing a lesson the back arrow does not work (#4979) * MER-3506 Fix back link * MER-3506 Add test * MER-3506 Make more robust SetRequestPath plug * [BUG FIX] [MER-3548] Change default analytic_version value to v2 for Section and Project (#4991) * [BUG FIX] [MER-3548] Change default analytic_version value to v2 for section and project * [BUG FIX] [MER-3548] Add a new test and adjust existing tests * [BUG FIX] [MER-3553] Lesson end date formatting breaks ability to load Home screen (#4992) * handle case when days_difference datetime cannot be localized * fix flaky test * [BUG FIX] [MER-3557] Not authorized message displayed to student on LTI launch (#4994) * remove institution_instructor role from list of allow_configure_section_roles * skip flaky test * bump version number * [FEATURE] [MER-3550] Hide agenda home screen (#4993) * [MER-3550] Adds agenda flag field to section * [MER-3550] Adds button to toggle agenda field value * [MER-3550] Renders agenda component conditionally * [MER-3550] Adds tests * only get the latest attempt for the page if there are multiple attempts (#4996) * [BUG FIX] [MER-3565] 500 error when launching assessments from a page link (#5003) * [MER-3565] Fix page link error on activity rendering * [MER-3565] Fix page link error on page rendering * [MER-3565] Add missing props * [MER-3565] Fix typescript tests * [MER-3565] Update docker compose command in CI test runner * fix quiz scores query (#5004) * [BUG FIX] [MER-3566] remove grade pass back optimization to filter out students that are no longer enrolled in the LMS course (#5006) * do not show 'Save' paywall settings button for non admin users * create SetPaywallSummary live session plug * add SetPaywallSummary plug to routes * add pay early message to delivery layouts * remove IO.inspect * add tests * improve stub current time for testing * remove commented test * bump version number * [BUG FIX] [MER-3573] torus learning proficiency algorithm leads to undesired results (#5007) * return not enough data if num first attempts is less than 3 * use sum to aggregate num first attempts * fixes explanation strategy ui bug (#5010) Co-authored-by: Raphael Gachuhi <rgachuhi@cmu.edu> * fix mix deps --------- Co-authored-by: Devesh Tiwari <70621864+dtiwarATS@users.noreply.github.com> Co-authored-by: Santiago Simoncelli <simoncellisantiago@gmail.com> Co-authored-by: Darren Siegel <siegel.darren@gmail.com> Co-authored-by: Raphael <rgachuhi@users.noreply.github.com> Co-authored-by: Raphael Gachuhi <rgachuhi@cmu.edu> Co-authored-by: Francisco-Castro <47334502+Francisco-Castro@users.noreply.github.com> Co-authored-by: Gastón Abellá <gaston@wyeworks.com> Co-authored-by: Nicolás Cirio <nicolas.cirio@wyeworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eliterate.atlassian.net/browse/MER-3553
This PR addresses an issue where
FormatDateTime.maybe_localized_datetimemight return{:not_localized, ...}which then gets piped intoDateTime.to_date()and crashes the page.