[BUG FIX] [MER-3671] Adaptive page styles broken after lesson publishing - part 2 #5044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliknebel
approved these changes
Aug 22, 2024
eliknebel
deleted the
MER-3671-adaptive-page-styles-broken-after-lesson-publishing-part-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the comment in the ticket
Before
Screen.Recording.2024-08-22.at.11.36.57.AM.mov
After
Screen.Recording.2024-08-22.at.11.35.52.AM.mov
The issue was identified after editing and publishing a page. So, when that event occurs, all active attempts of the edited page change their state from
:in_progresstorevised.Since the
RedirectAdaptiveChromelesslivesession plug was not considering:revisedstates to perform the redirect, the user ended up in the/lessonroute instead of the/adaptive_lessonone. Both layout templates for those routes are very similar, but the first one includes a modal, and that hidden modal was the one preventing the click from being correctly targeted to the dropdown.The same fix was extended to the
RedirectToLessonlivesession plug.All other cases were already addressed in this PR