[BUG FIX] [MER-3669] date groups do not match the dates rendered on the page #5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consistent due dates
eliknebel
changed the title
manelli
approved these changes
Aug 22, 2024
| ) | ||
|
|
||
| _ -> | ||
| [] | ||
| end) | ||
| end | ||
|
|
||
| defp to_localized_date(datetime, ctx) do |
There was a problem hiding this comment.
Maybe we can use the existing OliWeb.Common.FormatDateTime.maybe_localized_datetime/2 function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eliterate.atlassian.net/browse/MER-3669
Fixes an issue where date groupings were not being localized causing inconsistent due dates.
When grouping pages and assignments by due dates in the module index, the grouping was being determined by a non-localized datetime -> date conversion, losing the timezone information in the process. This resulted in some dates rendering off by a day, effectively rendering the UTC date, when actually it should have matched the other dates being displayed, rendered in the localized timezone.
The fix here is to localize the datetime before converting to naive date for grouping such that date groupings accurately match the actual dates being rendered on the page.