[CHORE] [MER-0000] Integrate v0.28.10 #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have finished [BUG FIX] [MER-3771] Delay submission to ensure all save state calls have finished
* account for unordered pages * use page_context instead of current_page
* directly provide atempt guid * Auto format --------- Co-authored-by: darrensiegel <darrensiegel@users.noreply.github.com>
* convert numeric to text input * cleanup * Auto format * change regex to allow 300. and .300 as valid numbers * allow same numbers in answer authoring as in delivery --------- Co-authored-by: darrensiegel <darrensiegel@users.noreply.github.com> Co-authored-by: Anders Weinstein <andersw@cs.cmu.edu>
…ls in certain cases (#5108) * fix an issue where account creation was not properly filtering out LTI accounts * remove redundant clause * Auto format --------- Co-authored-by: eliknebel <eliknebel@users.noreply.github.com>
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
darrensiegel
approved these changes
Sep 23, 2024
eliknebel
force-pushed
the
integrate-v0.28.10
branch
from
2e6b2b5
to
ddea257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH: Select "Merge Commit" when merging
I'm not sure how it got past CI, but it seems one of the hotfix changes broke a test (and also introduced a bug). Commit 19a16d9 fixes the issue. We'll likely need to make this change in the next v28 hotfix branch as well.