[ENHANCEMENT] [MER-3412] Image component has fixed aspect ratio based on image dimensions #5228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtiwarATS
commented
Oct 30, 2024
| @@ -114,6 +114,7 @@ const EditingCanvas: React.FC = () => { | |||
| // TODO: rename first param to partId | |||
| const handlePartConfigure = async (part: any, context: any) => { | |||
| /* console.log('[handlePartConfigure]', { part, context }); */ | |||
| dispatch(setCurrentPartPropertyFocus({ focus: false })); | |||
There was a problem hiding this comment.
These changes are related to #5211
dtiwarATS
commented
Oct 30, 2024
| @@ -122,7 +123,9 @@ export const generateMaxTryWorkflow = ( | |||
| incorrect.destinationId, | |||
| false, | |||
| 40, | |||
| options.threeTimesFeedback, | |||
| extraOptions.maxAttempt == '1' && incorrect.feedback != DEFAULT_INCORRECT_FEEDBACK | |||
There was a problem hiding this comment.
If the author sets the attempts to 1, the max attempt feedback should display on the first incorrect attempt unless the author has provided custom incorrect feedback. In such a case, the custom feedback should be displayed instead.
bsparks
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @bsparks, could you please look at the PR. Thanks.
This PR contains changes for the following tickets:
#2
Image.Resize.Based.on.Aspect.Ratio.mp4