[BUG FIX] [MER-4252] [MER-4255] restore basic page mutli tab with separate endpoint #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only render instructor feedback fro adaptive pages
eliknebel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eliterate.atlassian.net/browse/MER-4252
https://eliterate.atlassian.net/browse/MER-4255
This restores some previously removed changes which allow basic page assessments to be open in multiple browser windows and still work correctly.
The fix here follows the technical notes in the ticket by adding separate endpoints to save activity and part attempts for basic pages. These new endpoints, appended with
/activeare a slight variation of the original endpoints (which are still used by the adaptive player) and will only consider a currently active attempt, otherwise will return an error.It also fixes an issue related to https://eliterate.atlassian.net/browse/MER-3777 that was blocking testing this functionality for basic pages. The issue here was that this logic was only intended for adaptive pages but was crashing the prologue page for basic assessment pages. This issue was captured by MER-4255