Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: Slider Tweak #245

Closed
wants to merge 2 commits into from
Closed

Experiment: Slider Tweak #245

wants to merge 2 commits into from

Conversation

daltonfury42
Copy link
Collaborator

@maaverik This slider library that we are using, is a pain to control. The three dots at the bottom was not having proper margin, so I removed it. They also have a autoplay feature, which I enabled, to see what it would be like... What do you think?

If you didn't like autoplay, I can remove that, is it looking like too much motion on the page?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Preview branch generated at https://margin-fix.dpmhbfuiok7f8.amplifyapp.com

@daltonfury42
Copy link
Collaborator Author

Removing this was my main objective:

image

@maaverik
Copy link
Collaborator

The autoplay doesn't look bad. But the arrows are lost when I use mobile view on the preview so that's a problem. And the autoplay stopped after I enabled mobile view. It doesn't start even after switched back to desktop view. Is it the same on your side?

@daltonfury42
Copy link
Collaborator Author

daltonfury42 commented Sep 20, 2020

Let me investigate a bit more...

  1. The arrows automatically disappear on small screens to save space, it's a feature not a bug.

  2. The autoplay stopping on switching modes, I could not reproduce it here. A normal user won't switch like that, so hope that's ok. Can you try again, it's working for me on mobile view.

  3. Marking this as WIP. I want to play a bit more
    3a) I don't want two autoplaying sliders next to each other... That combined the loaders doesn't look very good. Too much movement on the page... I want to disable autoplay... but the problem there is that people don't then realise it's a slider. Dilemma...
    3b) I want to somehow control it's width.. limited it to some fixed rem.

@daltonfury42 daltonfury42 marked this pull request as draft September 20, 2020 20:46
@daltonfury42
Copy link
Collaborator Author

#210 has some examples of layouts, which might be better than a slider... let's not use sliders.

@github-actions
Copy link

Preview branch generated at https://margin-fix.dpmhbfuiok7f8.amplifyapp.com

@maaverik maaverik deleted the margin-fix branch October 18, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants