From b7c6385afc0a8826206d2a5dba735d18e1051bac Mon Sep 17 00:00:00 2001 From: John Rayes Date: Sun, 24 Dec 2023 21:34:28 -0700 Subject: [PATCH] nuke tab index Signed-off-by: John Rayes --- Themes/default/Calendar.template.php | 18 +++++++------- Themes/default/Display.template.php | 12 +++++----- Themes/default/GenericControls.template.php | 24 ++++--------------- Themes/default/ManageBoards.template.php | 8 +++---- Themes/default/ManageNews.template.php | 2 +- Themes/default/PersonalMessage.template.php | 6 ++--- Themes/default/Post.template.php | 26 ++++++++++----------- 7 files changed, 40 insertions(+), 56 deletions(-) diff --git a/Themes/default/Calendar.template.php b/Themes/default/Calendar.template.php index 22dc9cea736..35c6ae63bdf 100644 --- a/Themes/default/Calendar.template.php +++ b/Themes/default/Calendar.template.php @@ -756,12 +756,12 @@ function template_calendar_top($calendar_data) echo '
- '; + '; if (!empty($calendar_data['end_date'])) echo ' ', strtolower(Lang::$txt['to']), ' - '; + '; echo ' @@ -810,7 +810,7 @@ function template_event_post()
- +
'; @@ -849,19 +849,19 @@ function template_event_post()
', Lang::$txt['start'], ' - - + +
', Lang::$txt['end'], ' - - + +
- +
', Lang::$txt['calendar_timezone'], ' @@ -877,7 +877,7 @@ function template_event_post()
', Lang::$txt['location'], ' - +
'; diff --git a/Themes/default/Display.template.php b/Themes/default/Display.template.php index 9a361132423..74488d669f8 100644 --- a/Themes/default/Display.template.php +++ b/Themes/default/Display.template.php @@ -395,19 +395,19 @@ function template_main() sTemplateBodyEdit: ', Utils::JavaScriptEscape('
-
+
- ' . (Utils::$context['show_spellchecking'] ? ' ' : '') . ' + ' . (Utils::$context['show_spellchecking'] ? ' ' : '') . '
'), ', - sTemplateSubjectEdit: ', Utils::JavaScriptEscape(''), ', + sTemplateSubjectEdit: ', Utils::JavaScriptEscape(''), ', sTemplateBodyNormal: ', Utils::JavaScriptEscape('%body%'), ', sTemplateSubjectNormal: ', Utils::JavaScriptEscape('%subject%'), ', sTemplateTopSubject: ', Utils::JavaScriptEscape('%subject%'), ', - sTemplateReasonEdit: ', Utils::JavaScriptEscape(Lang::$txt['reason_for_edit'] . ': '), ', + sTemplateReasonEdit: ', Utils::JavaScriptEscape(Lang::$txt['reason_for_edit'] . ': '), ', sTemplateReasonNormal: ', Utils::JavaScriptEscape('%modify_text'), ', sErrorBorderStyle: ', Utils::JavaScriptEscape('1px solid red'), (Utils::$context['can_reply']) ? ', sFormRemoveAccessKeys: \'postmodify\'' : '', ' @@ -963,7 +963,7 @@ function template_quickreply() ', Lang::$txt['name'], ':
- +
'; if (empty(Config::$modSettings['guest_post_no_email'])) @@ -973,7 +973,7 @@ function template_quickreply() ', Lang::$txt['email'], ':
- +
'; } diff --git a/Themes/default/GenericControls.template.php b/Themes/default/GenericControls.template.php index dbc6a40888b..0062c4a60b9 100644 --- a/Themes/default/GenericControls.template.php +++ b/Themes/default/GenericControls.template.php @@ -90,23 +90,7 @@ function template_control_richedit_buttons($editor_id) '; - $tempTab = Utils::$context['tabindex']; - - if (!empty(Utils::$context['drafts_save'])) - $tempTab++; - elseif ($editor_context['preview_type']) - $tempTab++; - elseif (Utils::$context['show_spellchecking']) - $tempTab++; - - $tempTab++; - Utils::$context['tabindex'] = $tempTab; - foreach (Utils::$context['richedit_buttons'] as $name => $button) { - if ($name == 'spell_check') { - $button['onclick'] = 'oEditorHandle_' . $editor_id . '.spellCheckStart();'; - } - if ($name == 'preview') { $button['value'] = isset($editor_context['labels']['preview_button']) ? $editor_context['labels']['preview_button'] : $button['value']; $button['onclick'] = $editor_context['preview_type'] == Editor::PREVIEW_XML ? '' : 'return submitThisOnce(this);'; @@ -115,12 +99,12 @@ function template_control_richedit_buttons($editor_id) if ($button['show']) { echo ' - '; + '; } } echo ' - + '; // Start an instance of the auto saver if its enabled @@ -206,7 +190,7 @@ function template_control_verification($verify_id, $display_type = 'all', $reset
', Lang::$txt['visual_verification_sound'], ' / ', Lang::$txt['visual_verification_request_new'], '', $display_type != 'quick_reply' ? '
' : '', '
', Lang::$txt['visual_verification_description'], ':', $display_type != 'quick_reply' ? '
' : '', ' - +
'; } @@ -228,7 +212,7 @@ function template_control_verification($verify_id, $display_type = 'all', $reset echo '
', $verify_context->questions[$qIndex]['q'], ':
- questions[$qIndex]['is_error'] ? 'style="border: 1px red solid;"' : '', ' tabindex="', Utils::$context['tabindex']++, '" required> + questions[$qIndex]['is_error'] ? 'style="border: 1px red solid;"' : '', ' required>
'; } diff --git a/Themes/default/ManageBoards.template.php b/Themes/default/ManageBoards.template.php index 42f9ceaf2e3..0fc531a141c 100644 --- a/Themes/default/ManageBoards.template.php +++ b/Themes/default/ManageBoards.template.php @@ -146,7 +146,7 @@ function template_modify_category() ', Lang::$txt['name_on_display'], '
- +
', Lang::$txt['mboards_description'], '
@@ -160,7 +160,7 @@ function template_modify_category() ', Lang::$txt['collapse_desc'], '
- +
'; // Show any category settings added by mods using the 'integrate_edit_category' hook. @@ -185,10 +185,10 @@ function template_modify_category() if (isset(Utils::$context['category']['is_new'])) echo ' - '; + '; else echo ' - + '; echo ' diff --git a/Themes/default/ManageNews.template.php b/Themes/default/ManageNews.template.php index 748e82d8178..e9acc1669f2 100644 --- a/Themes/default/ManageNews.template.php +++ b/Themes/default/ManageNews.template.php @@ -216,7 +216,7 @@ function template_email_members_compose() ', Lang::$txt['subject'], '
- +
'; diff --git a/Themes/default/PersonalMessage.template.php b/Themes/default/PersonalMessage.template.php index 5ddd0407aeb..09f3fa3597b 100644 --- a/Themes/default/PersonalMessage.template.php +++ b/Themes/default/PersonalMessage.template.php @@ -1026,7 +1026,7 @@ function template_send() // Autosuggest will be added by the JavaScript later on. echo '
- '; + '; // A link to add BCC, only visible with JavaScript enabled. echo ' @@ -1045,7 +1045,7 @@ function template_send() ', Lang::$txt['pm_bcc'], ':
- +
'; @@ -1055,7 +1055,7 @@ function template_send() ', Lang::$txt['subject'], ':
- +
'; diff --git a/Themes/default/Post.template.php b/Themes/default/Post.template.php index 78108db89e9..d66f212942d 100644 --- a/Themes/default/Post.template.php +++ b/Themes/default/Post.template.php @@ -130,26 +130,26 @@ function template_main()
', Lang::$txt['calendar_event_title'], ' - +
', Lang::$txt['start'], ' - - + +
', Lang::$txt['end'], ' - - + +
- +
', Lang::$txt['calendar_timezone'], ' @@ -167,7 +167,7 @@ function template_main()
', Lang::$txt['location'], ' - +
@@ -185,7 +185,7 @@ function template_main()
', Lang::$txt['poll_question'], '
- +
'; // Loop through all the choices and print them out. @@ -195,7 +195,7 @@ function template_main() :
- +
'; echo ' @@ -1001,7 +1001,7 @@ function template_post_header() } } - echo ' tabindex="', Utils::$context['tabindex']++, '">'; + echo '>'; } // textarea elseif ($pf['input']['type'] === 'textarea') @@ -1028,7 +1028,7 @@ function template_post_header() } } - echo ' tabindex="', Utils::$context['tabindex']++, '">', !empty($pf['input']['attributes']['value']) ? $pf['input']['attributes']['value'] : '', ''; + echo '>', !empty($pf['input']['attributes']['value']) ? $pf['input']['attributes']['value'] : '', ''; } // Select menus are more complicated elseif ($pf['input']['type'] === 'select' && is_array($pf['input']['options'])) @@ -1054,7 +1054,7 @@ function template_post_header() } } - echo ' tabindex="', Utils::$context['tabindex']++, '">'; + echo '>'; // The options foreach ($pf['input']['options'] as $optlabel => $option) @@ -1161,7 +1161,7 @@ function template_post_header() echo ' ', $attribute, '="', $value, '"'; } - echo ' tabindex="', Utils::$context['tabindex']++, '"> ', isset($option['label']) ? $option['label'] : $optlabel, ''; + echo '> ', isset($option['label']) ? $option['label'] : $optlabel, ''; } echo '