Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Layout][Next.js] Load the content styles for the RichText component (without using file proxy) #1678

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Nov 30, 2023

Description / Motivation

This is implementation of loading stylesheets for CKEditor, but without using files proxy.
Based on pull request #1670

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Comment on lines +12 to +16
## Unreleased

### 🎉 New Features & Improvements

* `[sitecore-jss]` `[templates/nextjs]` Load the content styles for the RichText component [#1678](https://github.com/Sitecore/jss/pull/1678)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been under 21.5.1
I will fix this directly.

Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍🏼

@addy-pathania addy-pathania merged commit 1778f46 into release/21.0.0 Dec 1, 2023
1 check passed
@addy-pathania addy-pathania deleted the feature/JSS-1286 branch December 1, 2023 19:26
addy-pathania added a commit that referenced this pull request Dec 4, 2023
…mponent (without using file proxy) (#1678)"

This reverts commit 1778f46.
addy-pathania pushed a commit that referenced this pull request Dec 7, 2023
…(without using file proxy) (#1678)

* load content styles for rich text component

* fix linting errors

* update changelog

* fix linting error

* fix lint-samples step failing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants