Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/nextjs-styleguide] Ensure Bootstrap component is used #1710

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Jan 8, 2024

Description / Motivation

Scaffolding a nextjs styleguide+xmcloud app causes Event context to not be initialized. Ensuring Bootstrap is used in styleguide fixes this issue.
This should be cherrypicked in v21 branch ahead of 21.6 release.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team January 8, 2024 20:31
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@art-alexeyenko art-alexeyenko merged commit ca2b5fa into dev Jan 8, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the chores/adjust-bootstrap-styleguide branch January 8, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants