Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] Internal link in RichText is broken when nested tags are added #1718

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jan 18, 2024

Description / Motivation

The route handler needs to reference event.currentTarget instead of event.target. This change is necessary because we require parameters from the parent link tag, not the clicked element itself.

Testing Details

  • Unit Test Added
  • Manual Test/Other - tested using styleguide app

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko changed the title [sitecore-jss-nextjs] Internal link in RichText is broken when nestedtags are added [sitecore-jss-nextjs] Internal link in RichText is broken when nested tags are added Jan 18, 2024
@illiakovalenko illiakovalenko requested a review from a team January 18, 2024 11:05
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

@addy-pathania addy-pathania merged commit 1c23d78 into dev Jan 19, 2024
1 check passed
@addy-pathania addy-pathania deleted the bugfix/JSS-1454 branch January 19, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants