[sitecore-jss] Retry policy to handle transient network errors #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrauer
suggested changes
Feb 9, 2024
art-alexeyenko
requested changes
Feb 9, 2024
packages/create-sitecore-jss/src/templates/nextjs/src/lib/layout-service-factory.ts
Outdated
Show resolved
Hide resolved
ambrauer
approved these changes
Feb 9, 2024
Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
…ss into feature/jss-1594-retry-policy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds better retry handling approach on top of exiting:
User can pass retryStrategy to configure custom retry config to the services. They can customize the error codes and the number of retries. It consist of two functions shouldRetry and getDelay
If retryStrategy is not passed then defaultRetryStrategy will be used. The defaultStrategy handles 429 and the 500 error codes e.g. 502, 503, 504, 520, 521, 522, 523, 524.
getDalay calculates the delay (in milliseconds) before the next retry based on the given error, attempt count and exponential factor which defaults to 2.
This PR follows the Contribution Guide
Changelog updated
Description / Motivation
Testing Details
Types of changes