Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[templates/nextjs] Add default image remotePatterns config for whitelisting remote image hostnames #1732

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Feb 12, 2024

… hostnames

Description / Motivation

This PR adds default image remotePatterns configuration for whitelisting remove image hostnames.
Only Images from the whitelisted hostnames will be served from the Next.js Image Optimization API - see https://nextjs.org/docs/app/api-reference/components/image#remotepatterns

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@yavorsk yavorsk requested a review from a team February 12, 2024 16:34
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just left one comment for your consideration

@yavorsk yavorsk merged commit dd978d7 into dev Feb 12, 2024
1 check passed
@yavorsk yavorsk deleted the feature/JSS-1623 branch February 12, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants