[templates/nextjs] [sitecore-jss-nextjs] [sitecore-jss] Remove partial rendering implementation (EditingComponentPlaceholder component) #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiakovalenko
requested changes
Jun 17, 2024
CHANGELOG.md
Outdated
| @@ -24,7 +24,7 @@ Our versioning strategy is as follows: | |||
|
|
|||
| ### 🛠 Breaking Change | |||
|
|
|||
| * Editing Integration Support: ([#1776](https://github.com/Sitecore/jss/pull/1776))([#1792](https://github.com/Sitecore/jss/pull/1792))([#1773](https://github.com/Sitecore/jss/pull/1773))([#1797](https://github.com/Sitecore/jss/pull/1797))([#1800](https://github.com/Sitecore/jss/pull/1800))([#1803](https://github.com/Sitecore/jss/pull/1803))([#1806](https://github.com/Sitecore/jss/pull/1806))([#1809](https://github.com/Sitecore/jss/pull/1809))([#1814](https://github.com/Sitecore/jss/pull/1814))([#1816](https://github.com/Sitecore/jss/pull/1816))([#1819](https://github.com/Sitecore/jss/pull/1819)) | |||
| * Editing Integration Support: ([#1776](https://github.com/Sitecore/jss/pull/1776))([#1792](https://github.com/Sitecore/jss/pull/1792))([#1773](https://github.com/Sitecore/jss/pull/1773))([#1797](https://github.com/Sitecore/jss/pull/1797))([#1800](https://github.com/Sitecore/jss/pull/1800))([#1803](https://github.com/Sitecore/jss/pull/1803))([#1806](https://github.com/Sitecore/jss/pull/1806))([#1809](https://github.com/Sitecore/jss/pull/1809))([#1814](https://github.com/Sitecore/jss/pull/1814))([#1816](https://github.com/Sitecore/jss/pull/1816))([#1819](https://github.com/Sitecore/jss/pull/1819)[#1821](https://github.com/Sitecore/jss/pull/1821)) | |||
There was a problem hiding this comment.
This change is not related to Editing Integration, should be added just as a separate bullet point
docs/upgrades/unreleased.md
Outdated
| Sitecore Pages supports component rendering to avoid refreshing the entire page during component editing. | ||
| If you are using Experience Editor only, this logic can be removed, Layout can be left. | ||
| */} | ||
| {isComponentRendering ? ( |
There was a problem hiding this comment.
You can just provide this part as an example (including imports) that should be removed from the app, not sure if we need to copy/paste all the file content here. Like we are doing for other upgrade steps
CHANGELOG.md
Outdated
| @@ -36,6 +36,7 @@ Our versioning strategy is as follows: | |||
| * `[sitecore-jss]` Introduced `GraphQLEditingService` class to fetch editing data in Metadata Edit Mode. | |||
| * `[templates/nextjs-xmcloud]` Introduced _/lib/graphql-editing-service_ to fetch editing data in Metadata Edit Mode. | |||
| * `[templates/nextjs-xmcloud]` Added a new _page-props-factory/plugins/preview-mode_ plugin to handle both Chromes and Metadata Edit Mode. | |||
| * `[templates/nextjs]` `[sitecore-jss-nextjs]` `[sitecore-jss]` Remove EditingComponentPlaceholder as it will not be used by Pages in its current implementation | |||
There was a problem hiding this comment.
Can you add more details here, please?
Mention removed types. variables that could be used by Pages (e.g. RenderingType)
docs/upgrades/unreleased.md
Outdated
| @@ -134,4 +134,25 @@ | |||
| ... | |||
| } | |||
| ... | |||
| ``` | |||
|
|
|||
| * The implementation of 'EditingComponentPlaceholder' has been removed. Its purpose to avoid refreshing the entire page during component editing in Pages had never been fully utilized. The references to it and to `RenderingType` enum in `[[...path]].tsx` of the nextjs app (and in any custom code) should be removed: | |||
There was a problem hiding this comment.
Not related to nextjs-xmcloud, should be mentioned under nextjs section
|
@yavorsk Let's update the title a bit a be more specific on the feature, e.g. "[templates/nextjs] [sitecore-jss-nextjs] [sitecore-jss] Remove Partial Rendering implementation" |
yavorsk
changed the title
illiakovalenko
deleted the
feature/jss-3454-remove-editing-component-placeholder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR removes the EditingComponentPlaceholder implementation as it will not be used by Pages in this form:
consists of:
Testing Details
Types of changes