Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Github - Teams Integration #1823

Merged
merged 3 commits into from
Jun 17, 2024
Merged

[Chore] Github - Teams Integration #1823

merged 3 commits into from
Jun 17, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Jun 17, 2024 •
edited
Loading

Description / Motivation

Post announcements about the release on teams channel.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore

@addy-pathania addy-pathania requested a review from a team June 17, 2024 13:05
illiakovalenko
illiakovalenko approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍
Can you, please, move PR description under the appropriate section? to follow our format

@illiakovalenko
Copy link
Contributor

@sc-addypathania Please, update PR type. It's not a feature, it's chore

@addy-pathania addy-pathania merged commit 07fec22 into dev Jun 17, 2024
1 check passed
@addy-pathania addy-pathania deleted the feature/jss-3421-teams-notification branch June 17, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @illiakovalenko