[sitecore-jss-react] [sitecore-jss-nextjs] Default Placeholder Content for empty fields in editMode metadata #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iting components for text and image; modify Link and Text field components
…h withEmptyValueEditingPlaceholder
art-alexeyenko
requested changes
Jun 24, 2024
packages/sitecore-jss-react/src/enhancers/withEmptyValueEditingPlaceholder.tsx
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-react/src/enhancers/withEmptyValueEditingPlaceholder.tsx
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-react/src/enhancers/withEmptyValueEditingPlaceholder.tsx
Outdated
Show resolved
Hide resolved
…tingPlaceholder from sitecore-jss-nextjs package
yavorsk
force-pushed
the
feature/JSS-3455
branch
from
786ecb2
to
c1164a7
Compare
… withEmptyFieldEditingComponent
…eld components; some renamings and additional code comments
illiakovalenko
requested changes
Jul 5, 2024
packages/sitecore-jss-react/src/enhancers/withEmptyFieldEditingComponent.tsx
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-react/src/enhancers/withEmptyFieldEditingComponent.tsx
Show resolved
Hide resolved
| } | ||
|
|
||
| return true; | ||
| } else if (typeof fieldValue === 'number') { |
There was a problem hiding this comment.
Suggested change
| } else if (typeof fieldValue === 'number') { | |
| } else if (typeof fieldValue === 'number') { | |
| // Avoid returning true for 0 |
packages/sitecore-jss-react/src/enhancers/withEmptyFieldEditingComponent.tsx
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-react/src/enhancers/withEmptyFieldEditingComponent.test.tsx
Outdated
Show resolved
Hide resolved
| expect(rendered.html()).to.equal(expected.html()); | ||
| }); | ||
|
|
||
| it('Should render custom empty value placeholder if provided via props if field value is empty in metadata edit mode', () => { |
There was a problem hiding this comment.
Suggested change
| it('Should render custom empty value placeholder if provided via props if field value is empty in metadata edit mode', () => { | |
| it('Should render custom empty component if provided via props if field value is empty in metadata edit mode', () => { |
packages/sitecore-jss-react/src/enhancers/withEmptyFieldEditingComponent.test.tsx
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-react/src/enhancers/withEmptyFieldEditingComponent.test.tsx
Outdated
Show resolved
Hide resolved
…mments, update some existing comments
…eld components; update Image and Link unit tests
illiakovalenko
requested changes
Jul 8, 2024
There was a problem hiding this comment.
Looks good!
See some other comments below
Also, revisit comments:
1- #1831 (comment)
2- #1831 (comment)
packages/sitecore-jss-react/src/enhancers/withEmptyFieldEditingComponent.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR enhances the rendering of fields in editing mode for editMode metadata. When a field value is empty, a placeholder content should be rendered to signify that the field has no value. The placeholder should be interactable, so user can add value to the field. Additionally developers can provide their own custom empty field placeholder component via the field's
emptyValueEditingPlaceholderprop, which will be rendered instead of the default one.The fields with this functionality are:
Testing Details
Types of changes