Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-react] [sitecore-jss-nextjs] Default Placeholder Content for empty fields in editMode metadata #1831

Merged
merged 25 commits into from
Jul 8, 2024
Merged

[sitecore-jss-react] [sitecore-jss-nextjs] Default Placeholder Content for empty fields in editMode metadata #1831

merged 25 commits into from
Jul 8, 2024

Commits on Jun 23, 2024

  1. default empty field editing placeholder for text field component

    @yavorsk
    yavorsk committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    de2dc7c View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. add withEmptyPlaceholderValue HOC; unit tests; default empty field ed… 

    …iting components for text and image; modify Link and Text field components
    @yavorsk
    yavorsk committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e01330f View commit details
    Browse the repository at this point in the history

  2. modify Date, Image, RichText react components to use withEmptyValueEd… 

    …itingPlaceholder
    @yavorsk
    yavorsk committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    c0d4681 View commit details
    Browse the repository at this point in the history

  3. update Link, NextImage, RichText nextjs fields components to work wit… 

    …h withEmptyValueEditingPlaceholder
    @yavorsk
    yavorsk committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    32bfea9 View commit details
    Browse the repository at this point in the history

  4. add proptype for custom empty value placeholder component prop

    @yavorsk
    yavorsk committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    be9b0be View commit details
    Browse the repository at this point in the history

  5. added comments, fixed lint errors

    @yavorsk
    yavorsk committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2fd41cc View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. fix lint errors

    @yavorsk
    yavorsk committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    801ebf6 View commit details
    Browse the repository at this point in the history

  2. reexport default empty field editing components and withEmptyValueEdi… 

    …tingPlaceholder from sitecore-jss-nextjs package
    @yavorsk
    yavorsk committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    237d1bd View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. renamings HOC, properties - withEmptyFieldEditingComponent

    @yavorsk
    yavorsk committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    c1164a7 View commit details
    Browse the repository at this point in the history

  2. update hasValue logic

    @yavorsk
    yavorsk committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    79a0b4e View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. react field components - extract common properties into EditableField… 

    …Props interface
    @yavorsk
    yavorsk committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    085e09b View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. introduce a function fieldValueIsEmpty in base packages and use it in… 

    … withEmptyFieldEditingComponent
    @yavorsk
    yavorsk committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    aca9f14 View commit details
    Browse the repository at this point in the history

  2. fix lint error

    @yavorsk
    yavorsk committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    881362c View commit details
    Browse the repository at this point in the history

  3. fix lint errors

    @yavorsk
    yavorsk committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    54f0282 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. introduced FieldMetadata interface in core package; use it accross fi… 

    …eld components; some renamings and additional code comments
    @yavorsk
    yavorsk committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    abbb0d7 View commit details
    Browse the repository at this point in the history

  2. update withEmptyEditingComponent hoc to accept single options parameter

    @yavorsk
    yavorsk committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a1edea7 View commit details
    Browse the repository at this point in the history

  3. add unit tests for isValueEmpty; isValueEmpty update

    @yavorsk
    yavorsk committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6a94a33 View commit details
    Browse the repository at this point in the history

  4. isFieldValueEmpty - account for boolean value; add additional code co… 

    …mments, update some existing comments
    @yavorsk
    yavorsk committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    052fc3b View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. isEmptyField refactoring and unit tests update

    @yavorsk
    yavorsk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    74960b3 View commit details
    Browse the repository at this point in the history

  2. unit tests update

    @yavorsk
    yavorsk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    48a2af2 View commit details
    Browse the repository at this point in the history

  3. update emptyFieldComponent prop proptype; use isFieldValueEmpty in fi… 

    …eld components; update Image and Link unit tests
    @yavorsk
    yavorsk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    62bf073 View commit details
    Browse the repository at this point in the history

  4. update nextjs Link and NextImage unit tests, small updates

    @yavorsk
    yavorsk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2a05d7c View commit details
    Browse the repository at this point in the history

  5. some test title updates

    @yavorsk
    yavorsk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    534a0f2 View commit details
    Browse the repository at this point in the history

  6. add additional check for metadata for isEditing var in next richtext

    @yavorsk
    yavorsk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    b669ab5 View commit details
    Browse the repository at this point in the history

  7. add clarifying comment

    @yavorsk
    yavorsk committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f18852a View commit details
    Browse the repository at this point in the history