[Editing Integration] Make sc_variant and sc_version query string params optional
#1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addy-pathania
changed the title
sc_variant and sc_version optionalsc_variant and sc_version query string params optional
illiakovalenko
requested changes
Jul 4, 2024
There was a problem hiding this comment.
- Should GraphQLEditingService be updated, since version is optional now?
- If variantId is not present, we can't personalize layout
- Please, update the description of the PR
packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.test.ts
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.test.ts
Outdated
Show resolved
Hide resolved
…ware.ts Co-authored-by: Illia Kovalenko <23364749+illiakovalenko@users.noreply.github.com>
illiakovalenko
requested changes
Jul 5, 2024
packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.ts
Outdated
Show resolved
Hide resolved
illiakovalenko
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Make
sc_variantandsc_versionquery string params optional for the /editing/render endppointTesting Details
Types of changes