Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React][Next.js] DateField empty value is not treated as empty #1836

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jul 11, 2024

Description / Motivation

The default DateField value provided by Layout Service is date, we need to rely on it and on empty string value as well

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team July 11, 2024 07:48
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
As discussed: there is a potential issue if we have a text field and its value is equal to the default empty date value - then the field will be treated as empty. We decided to not cover this edge case, since the scenario is not valid in general.

@illiakovalenko illiakovalenko merged commit 4a1519e into dev Jul 11, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the bugfix/JSS-3553 branch July 11, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants