Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] Fix edit mode for localhost #1849

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Jul 24, 2024

Description / Motivation

Fix CORs issue for editMode when pointing Pages to a running localhost instance to use as the site editing host by modifying the cookies set by the setPreviewData from SameSite=Lax to SameSite=None

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team July 24, 2024 00:56
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!
Maybe just add a comment above the code to explain why we are modifying the cookie

Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me👍

@addy-pathania addy-pathania merged commit 6649e26 into dev Jul 24, 2024
1 check passed
@addy-pathania addy-pathania deleted the bugfix/jss-3606-edit-mode branch July 24, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants