From 0732b8bfaa1eaab60fbfa43be526ac38208fb9db Mon Sep 17 00:00:00 2001 From: Sumon Sen Date: Fri, 26 Jul 2024 02:48:30 +0530 Subject: [PATCH 1/6] #1834 link href updated with the ternary operator --- packages/sitecore-jss-react/src/components/Link.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sitecore-jss-react/src/components/Link.tsx b/packages/sitecore-jss-react/src/components/Link.tsx index 75130b9ad8..c5c03c98f6 100644 --- a/packages/sitecore-jss-react/src/components/Link.tsx +++ b/packages/sitecore-jss-react/src/components/Link.tsx @@ -97,7 +97,7 @@ export const Link: React.FC = withFieldMetadata Date: Fri, 26 Jul 2024 02:51:03 +0530 Subject: [PATCH 2/6] reverted back --- packages/sitecore-jss-react/src/components/Link.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sitecore-jss-react/src/components/Link.tsx b/packages/sitecore-jss-react/src/components/Link.tsx index c5c03c98f6..75130b9ad8 100644 --- a/packages/sitecore-jss-react/src/components/Link.tsx +++ b/packages/sitecore-jss-react/src/components/Link.tsx @@ -97,7 +97,7 @@ export const Link: React.FC = withFieldMetadata Date: Fri, 26 Jul 2024 02:53:26 +0530 Subject: [PATCH 3/6] #1834 - Link href updated --- packages/sitecore-jss-react/src/components/Link.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sitecore-jss-react/src/components/Link.tsx b/packages/sitecore-jss-react/src/components/Link.tsx index 75130b9ad8..c5c03c98f6 100644 --- a/packages/sitecore-jss-react/src/components/Link.tsx +++ b/packages/sitecore-jss-react/src/components/Link.tsx @@ -97,7 +97,7 @@ export const Link: React.FC = withFieldMetadata Date: Fri, 26 Jul 2024 16:03:08 +0530 Subject: [PATCH 4/6] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 25f8a47f76..e7e1b45fa3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ Our versioning strategy is as follows: * `[sitecore-jss]` `[sitecore-jss-react]` DateField empty value is not treated as empty ([#1836](https://github.com/Sitecore/jss/pull/1836)) * `[templates/nextjs-sxa]` Fix styles of title component in metadata mode. ([#1839](https://github.com/Sitecore/jss/pull/1839)) * `[templates/nextjs-sxa]` Fix missing value of field property in Title component. ([#1842](https://github.com/Sitecore/jss/pull/1842)) +* `[packages/sitecore-jss-react/src/components/Link]` Fix link component is not checking if href is undefined. ([#1842](https://github.com/Sitecore/jss/pull/1856)) ### 🎉 New Features & Improvements From 9213e0dff3396bae47ba8cbb289e5d8c9db82031 Mon Sep 17 00:00:00 2001 From: Sumon Sen Date: Fri, 26 Jul 2024 16:03:36 +0530 Subject: [PATCH 5/6] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e7e1b45fa3..6304789e7a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,7 +19,7 @@ Our versioning strategy is as follows: * `[sitecore-jss]` `[sitecore-jss-react]` DateField empty value is not treated as empty ([#1836](https://github.com/Sitecore/jss/pull/1836)) * `[templates/nextjs-sxa]` Fix styles of title component in metadata mode. ([#1839](https://github.com/Sitecore/jss/pull/1839)) * `[templates/nextjs-sxa]` Fix missing value of field property in Title component. ([#1842](https://github.com/Sitecore/jss/pull/1842)) -* `[packages/sitecore-jss-react/src/components/Link]` Fix link component is not checking if href is undefined. ([#1842](https://github.com/Sitecore/jss/pull/1856)) +* `[packages/sitecore-jss-react/src/components/Link]` Fix link component is not checking if href is undefined. ([#1856](https://github.com/Sitecore/jss/pull/1856)) ### 🎉 New Features & Improvements From b7866b4d97af18589a0b3f5163fd7ca3655800fb Mon Sep 17 00:00:00 2001 From: Sumon Sen Date: Fri, 26 Jul 2024 18:51:19 +0530 Subject: [PATCH 6/6] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6304789e7a..1714c0c892 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,7 +19,7 @@ Our versioning strategy is as follows: * `[sitecore-jss]` `[sitecore-jss-react]` DateField empty value is not treated as empty ([#1836](https://github.com/Sitecore/jss/pull/1836)) * `[templates/nextjs-sxa]` Fix styles of title component in metadata mode. ([#1839](https://github.com/Sitecore/jss/pull/1839)) * `[templates/nextjs-sxa]` Fix missing value of field property in Title component. ([#1842](https://github.com/Sitecore/jss/pull/1842)) -* `[packages/sitecore-jss-react/src/components/Link]` Fix link component is not checking if href is undefined. ([#1856](https://github.com/Sitecore/jss/pull/1856)) +* `[packages/sitecore-jss-react/src/components/Link.tsx]` Fix link component is not checking if href is undefined. ([#1856](https://github.com/Sitecore/jss/pull/1856)) ### 🎉 New Features & Improvements