Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] Fix page not found error on pages. #1883

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Aug 12, 2024

Description / Motivation

When switching between page and subpage on Pages we get Page not found error because there are duplicate cookies set by nextjs setPreviewData function on each page route. There should be single active preview cookie at the root of your session.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team August 12, 2024 20:48
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there some unit test that will need updating (or should be added)?

@addy-pathania
Copy link
Contributor Author

Looks good. Is there some unit test that will need updating (or should be added)?

Nothing really to update in tests since it was a optional options param in the setPreviewData function.

@addy-pathania addy-pathania merged commit c77daf0 into dev Aug 12, 2024
1 check passed
@addy-pathania addy-pathania deleted the bugfix/jss-3818 branch August 12, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants