Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[create-sitecore-jss] Only put FETCH_WITH for SXP template, pass proxyPath to prompt #1884

Merged
merged 2 commits into from
Aug 13, 2024
Merged

[create-sitecore-jss] Only put FETCH_WITH for SXP template, pass proxyPath to prompt #1884

merged 2 commits into from
Aug 13, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Aug 12, 2024 •
edited
Loading

Description / Motivation

  • fetchWith prompt will only appear during angular-sxp intializer execution - but it's expected in base angular template. We prevent an error from happening by moving FETCH_WITH into sxp-only .env file
  • proxyAppDestination from flags was ignored by prompt logic in angular-xmcloud initializer. This is fixed too.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team August 12, 2024 20:56
addy-pathania
addy-pathania approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@art-alexeyenko art-alexeyenko changed the title [create-sitecore-jss] Only put FETCH_WITH for SXP template [create-sitecore-jss] Only put FETCH_WITH for SXP template, pass proxyPath to prompt Aug 12, 2024
@art-alexeyenko art-alexeyenko merged commit 41f0943 into dev Aug 13, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the bug/fetchWith-not-popularted branch August 13, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

@addy-pathania addy-pathania addy-pathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@art-alexeyenko @illiakovalenko @addy-pathania