Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pubsub falsy message #297

Merged
merged 2 commits into from
Aug 17, 2017
Merged

Fix pubsub falsy message #297

merged 2 commits into from
Aug 17, 2017

Conversation

Steven-Chan
Copy link

connect #228

@Steven-Chan Steven-Chan requested a review from cheungpat August 11, 2017 10:32
@cheungpat
Copy link
Contributor

I couldn’t decide if this is the correct resolution for refs #228, giving this to @rickmak

@cheungpat cheungpat assigned rickmak and unassigned cheungpat Aug 17, 2017
@cheungpat cheungpat requested review from rickmak and removed request for cheungpat August 17, 2017 03:13
@rickmak rickmak merged commit 6d21022 into SkygearIO:master Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickmak rickmak Awaiting requested review from rickmak

Assignees

@rickmak rickmak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Steven-Chan @cheungpat @rickmak