Reuse the zmq socket or use go chan #160

rickmak · 2016-10-11T08:05:07Z

Current zmqTransport is very generous on opening new sock https://github.com/SkygearIO/skygear-server/blob/master/pkg/server/plugin/zmq/rpc.go#L260

Since the zmq socket deallocation is asynchronous. The default 1024 limit will be easily reach.

Skygear Server Date/Version: v0.17.0
Application Platform:
Is this a regression?
Attached logs, screenshots

Actual Results

#150

This will resolve socket exhaust problem on high concurrency. refs #160

rickmak added the in progress label Oct 11, 2016

royuen assigned rickmak Oct 12, 2016

rickmak mentioned this issue Oct 14, 2016

WIP: Use channel in messging between goroutine in stead of zmq.REQ #163

Closed

royuen added In Review and removed in progress labels Oct 17, 2016

This was referenced Oct 20, 2016

Use channel in messging between goroutine in stead of zmq.REQ #167

Closed

Use channel in messaging between goroutine in stead of zmq.REQ #168

Closed

Use channel in messaging between goroutine instead of zmq.REQ #177

Merged

royuen added In Review and removed in progress labels Oct 25, 2016

cheungpat mentioned this issue Oct 25, 2016

Use channel in messaging between goroutine instead of zmq.REQ #181

Closed

cheungpat added a commit that referenced this issue Oct 25, 2016

Use channel in messaging between goroutine instead of zmq.REQ

c3b7509

This will resolve socket exhaust problem on high concurrency. refs #160

cheungpat closed this as completed Oct 25, 2016

cheungpat removed the In Review label Oct 25, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reuse the zmq socket or use go chan #160

Reuse the zmq socket or use go chan #160

rickmak commented Oct 11, 2016 •

edited

Loading

Reuse the zmq socket or use go chan #160

Reuse the zmq socket or use go chan #160

Comments

rickmak commented Oct 11, 2016 • edited Loading

Actual Results

rickmak commented Oct 11, 2016 •

edited

Loading