A few DeskLock features and addons #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8aa4960c03d710ca7889c8d91701ca5b5376c9ef
…sor. (╯°□°)╯ sʞɔolɔ Change-Id: Iba38e37bffe91d0d5bd9bb8922b4c168386ebfd9 (cherry picked from commit 106cfa2bca37303a93e1826c04d88783aa15b52d)
If you open the Clock countdown time and input 99h99m99s it will actually translate to 100 hours, 40 minutes and 39 seconds as expected. When leaving the app it will show a notification with the remaining time and if there are more than 100 hours it will fail to show that part and only show "40 minutes remaining". This patch fixes allows for 100 as a valid input. Change-Id: Ib3621691aaa3a449262cb9e3601d39283bb808f8
Change-Id: I13ca3156c34eccdd8f60d8585281ae0585aac58e Conflicts: res/values/cm_strings.xml
Allow themers to tint the background colors according to the hour. CM words: The background colors are currently defined as a hard coded array in Utils.java. This patch moves this array to cm_arrays.xml and exposes the colors of the array in cm_colors.xml for theming Change-Id: Id72867ee82edd28bc120223be96c34448d79f1ae
Reported issue: AlarmManager would not properly reschedule repeat alarm if the user manually adjusted date/time to before the next scheduled instance of the alarm. Steps to repro issue: 1.Set an alarm for 18:00 when system time is 19:00. 2.Modify the system time to 17:50 3.Note that alarm does not fire at 18:00 Thanks to Guotao Deng for identification and initial fix. Based on this patch, and adapted for CM: https://android-review.googlesource.com/#/c/147815/ Change-Id: Ifa7b85ab93583afaf4a248e13d726997b68822ed Conflicts: src/com/android/deskclock/provider/Alarm.java
… [2/2]" This reverts commit 93ef7e7. Conflicts: src/com/android/deskclock/SettingsActivity.java
PS: DeskClock : Fix alarm statusbar icon visibility PS 23May2015: checkboxpref to switchpref, removed useless 755 permission on AlarmNotifications.java, moved strings to slim_strings Change-Id: I76591715a20cd8286b3ef9602a55836cc9b93047 Conflicts: res/values/custom_strings.xml src/com/android/deskclock/ScreensaverSettingsActivity.java src/com/android/deskclock/SettingsActivity.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SlimSaber friends, could you test building with this changes? I got a successful build with those, but I couldn't test the SystemUI FC at my ROM, if you test it out.
Includes:
I'll add some more stuff back from CM as soon as my ROM totally gets fixed.
In case you want to help me catching the problem in SystemUI:
http://www.slimdevs.com/VexxoAOSP/logs/
Thanks @fusionjack