Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NFTAttestation Request EIP712 #209

Closed
jot2re opened this issue Nov 22, 2021 · 2 comments · Fixed by #210
Closed

Make NFTAttestation Request EIP712 #209

jot2re opened this issue Nov 22, 2021 · 2 comments · Fixed by #210
Assignees
@jot2re
Labels
enhancement New feature or request

Comments

@jot2re
Copy link
Collaborator

jot2re commented Nov 22, 2021 •
edited
Loading

Per request from @JamesSmartCell and for general convenience the NFTAttestation request should be done using EIP712.
@jot2re jot2re added the enhancement New feature or request label Nov 22, 2021
@jot2re jot2re self-assigned this Nov 22, 2021
@jot2re
Copy link
Collaborator Author

jot2re commented Nov 22, 2021

@oleggrib I will do this in Java, but I think it will also involve a bit of JS update afterwards unfortunately. I will ping you when needed.

@hboon
Copy link
Member

hboon commented Nov 22, 2021

@jot2re wrong James :)

@jot2re jot2re linked a pull request Nov 28, 2021 that will close this issue
Added eip712 signature version to signed NFT attestation #210
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jot2re jot2re

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added eip712 signature version to signed NFT attestation SmartTokenLabs/attestation
2 participants
@hboon @jot2re