Added eip712 signature version to signed NFT attestation #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… refactoring on related classes
This was
linked to
issues
Nov 26, 2021
|
Pushed the changes to main as they contain many refactoring. I ensured everything is backwards compatible, and validated that things work with attestation.id. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes issue #201
Furthermore this PR contains quite a bit of refactoring, renaming, added tests, and cleaning up on the files I have to touch in the process.
In general I refactored things so we can use any kind of ASN encoded object in an EIP712 signature with only a couple of lines of code, this makes it easy to update and generalise to other cryptographic objects.
The main things is that we now have two versions of SignedNFTAttestation, one based on the the approach we had before (constructing an ASN object containing the signature), the other obviously uses the EIP712 approach and shows the usual EIP712 fields and a short hex field for the underlying NFTAttestation to be signed.