From 8be5f32e1aea8e582105298e4466700ba7eff3e5 Mon Sep 17 00:00:00 2001
From: jane <jiantaolovebingbing@gmail.com>
Date: Tue, 10 Nov 2020 12:27:47 +0800
Subject: [PATCH 1/2] Fix: Fix warning from anchor component

---
 src/app/components/Anchor/AnchorUndraggable.jsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/app/components/Anchor/AnchorUndraggable.jsx b/src/app/components/Anchor/AnchorUndraggable.jsx
index d9bd903d2d..e8ace6ee37 100644
--- a/src/app/components/Anchor/AnchorUndraggable.jsx
+++ b/src/app/components/Anchor/AnchorUndraggable.jsx
@@ -11,7 +11,7 @@ class AnchorUndraggable extends PureComponent {
             PropTypes.func,
             PropTypes.string
         ]),
-        draggable: PropTypes.bool,
+        draggable: PropTypes.string,
         disabled: PropTypes.bool,
         href: PropTypes.string,
         onClick: PropTypes.func,

From bca53a53cbbb631948496e1b18dc019dd54ba5c0 Mon Sep 17 00:00:00 2001
From: jane <jiantaolovebingbing@gmail.com>
Date: Tue, 10 Nov 2020 18:05:01 +0800
Subject: [PATCH 2/2] Refactor: Change draggable attribute to bool type on
 Anchot componnent

---
 src/app/components/Anchor/AnchorUndraggable.jsx             | 4 ++--
 src/app/components/OptionalDropdown/OptionalDropdown.jsx    | 1 -
 src/app/containers/Header/Header.jsx                        | 1 -
 src/app/widgets/CNCPath/ImageProcessMode.jsx                | 3 +--
 src/app/widgets/CncLaserObjectList/ObjectListBox.jsx        | 1 -
 src/app/widgets/CncLaserShared/Transformation.jsx           | 2 +-
 src/app/widgets/LaserParams/ImageProcessMode.jsx            | 6 ++----
 src/app/widgets/PrintingMaterial/Material.jsx               | 1 -
 .../PrintingVisualizer/VisualizerCameraOperations.jsx       | 5 -----
 9 files changed, 6 insertions(+), 18 deletions(-)

diff --git a/src/app/components/Anchor/AnchorUndraggable.jsx b/src/app/components/Anchor/AnchorUndraggable.jsx
index e8ace6ee37..2797d1f374 100644
--- a/src/app/components/Anchor/AnchorUndraggable.jsx
+++ b/src/app/components/Anchor/AnchorUndraggable.jsx
@@ -11,7 +11,7 @@ class AnchorUndraggable extends PureComponent {
             PropTypes.func,
             PropTypes.string
         ]),
-        draggable: PropTypes.string,
+        draggable: PropTypes.bool,
         disabled: PropTypes.bool,
         href: PropTypes.string,
         onClick: PropTypes.func,
@@ -55,7 +55,7 @@ class AnchorUndraggable extends PureComponent {
         } = this.props;
         const {
             componentClass,
-            draggable = 'false',
+            draggable = false,
             ...props
         } = this.props;
         const Component = componentClass || 'a';
diff --git a/src/app/components/OptionalDropdown/OptionalDropdown.jsx b/src/app/components/OptionalDropdown/OptionalDropdown.jsx
index 1b1e01781b..0c739c5d38 100644
--- a/src/app/components/OptionalDropdown/OptionalDropdown.jsx
+++ b/src/app/components/OptionalDropdown/OptionalDropdown.jsx
@@ -17,7 +17,6 @@ const OptionalDropdown = (props) => {
                         <Anchor
                             onClick={onClick}
                             disabled={disabled}
-                            draggable="false"
                         >
                             <i className={classNames(styles.icon, hidden ? styles['icon-unchecked'] : styles['icon-checked'])} />
                             <span>{title}</span>
diff --git a/src/app/containers/Header/Header.jsx b/src/app/containers/Header/Header.jsx
index b081d0d173..6b23987106 100644
--- a/src/app/containers/Header/Header.jsx
+++ b/src/app/containers/Header/Header.jsx
@@ -18,7 +18,6 @@ const Logo = memo(() => (
     <Anchor
         className="navbar-brand"
         href="/#/workspace"
-        draggable='false'
         title={`${settings.name} ${settings.version}`}
         style={{ position: 'relative' }}
     >
diff --git a/src/app/widgets/CNCPath/ImageProcessMode.jsx b/src/app/widgets/CNCPath/ImageProcessMode.jsx
index b3573443f6..02a2e16cf3 100644
--- a/src/app/widgets/CNCPath/ImageProcessMode.jsx
+++ b/src/app/widgets/CNCPath/ImageProcessMode.jsx
@@ -38,7 +38,7 @@ class ImageProcessMode extends PureComponent {
 
         return (
             <React.Fragment>
-                <Anchor className="sm-parameter-header" onClick={this.actions.onToggleExpand} draggable="false">
+                <Anchor className="sm-parameter-header" onClick={this.actions.onToggleExpand}>
                     <span className="fa fa-arrows-alt sm-parameter-header__indicator" />
                     <span className="sm-parameter-header__title">{i18n._('Processing Mode')}</span>
                     <span className={classNames(
@@ -61,7 +61,6 @@ class ImageProcessMode extends PureComponent {
                             >
                                 <div className={classNames(styles['laser-mode'], { [styles.selected]: this.props.mode === 'greyscale' })}>
                                     <Anchor
-                                        draggable="false"
                                         className={styles['laser-mode__btn']}
                                         onClick={() => actions.changeSelectedModelMode('greyscale')}
                                     >
diff --git a/src/app/widgets/CncLaserObjectList/ObjectListBox.jsx b/src/app/widgets/CncLaserObjectList/ObjectListBox.jsx
index 2fa980cfa4..a43a7cd34e 100644
--- a/src/app/widgets/CncLaserObjectList/ObjectListBox.jsx
+++ b/src/app/widgets/CncLaserObjectList/ObjectListBox.jsx
@@ -110,7 +110,6 @@ class ObjectListBox extends PureComponent {
                                                 styles.name,
                                                 styles.bt
                                             )}
-                                            draggable="false"
                                             onClick={(event) => this.actions.onClickModelNameBox(model, event)}
                                         >
                                             <span
diff --git a/src/app/widgets/CncLaserShared/Transformation.jsx b/src/app/widgets/CncLaserShared/Transformation.jsx
index 8bccb9abe9..2c990c6716 100644
--- a/src/app/widgets/CncLaserShared/Transformation.jsx
+++ b/src/app/widgets/CncLaserShared/Transformation.jsx
@@ -111,7 +111,7 @@ class Transformation extends PureComponent {
         const actions = this.actions;
         return (
             <React.Fragment>
-                <Anchor className="sm-parameter-header" onClick={this.actions.onToggleExpand} draggable="false">
+                <Anchor className="sm-parameter-header" onClick={this.actions.onToggleExpand}>
                     <span className="fa fa-arrows-alt sm-parameter-header__indicator" />
                     <span className="sm-parameter-header__title">{i18n._('Transformation')}</span>
                     <span className={classNames(
diff --git a/src/app/widgets/LaserParams/ImageProcessMode.jsx b/src/app/widgets/LaserParams/ImageProcessMode.jsx
index a7854bccd2..a54e0cb726 100644
--- a/src/app/widgets/LaserParams/ImageProcessMode.jsx
+++ b/src/app/widgets/LaserParams/ImageProcessMode.jsx
@@ -44,7 +44,7 @@ class ImageProcessMode extends PureComponent {
 
         return (
             <React.Fragment>
-                <Anchor className="sm-parameter-header" onClick={this.actions.onToggleExpand} draggable="false">
+                <Anchor className="sm-parameter-header" onClick={this.actions.onToggleExpand}>
                     <span className="fa fa-arrows-alt sm-parameter-header__indicator" />
                     <span className="sm-parameter-header__title">{i18n._('Processing Mode')}</span>
                     <span className={classNames(
@@ -64,7 +64,7 @@ class ImageProcessMode extends PureComponent {
                             <div className={styles['laser-modes']}>
                                 <div className={classNames(styles['laser-mode'], { [styles.selected]: this.props.mode === 'bw' })}>
                                     <Anchor
-                                        draggable="false"
+
                                         disabled={disabled}
                                         className={styles['laser-mode__btn']}
                                         onClick={() => actions.changeSelectedModelMode('bw')}
@@ -75,7 +75,6 @@ class ImageProcessMode extends PureComponent {
                                 </div>
                                 <div className={classNames(styles['laser-mode'], { [styles.selected]: this.props.mode === 'greyscale' })}>
                                     <Anchor
-                                        draggable="false"
                                         disabled={disabled}
                                         className={styles['laser-mode__btn']}
                                         onClick={() => actions.changeSelectedModelMode('greyscale')}
@@ -86,7 +85,6 @@ class ImageProcessMode extends PureComponent {
                                 </div>
                                 <div className={classNames(styles['laser-mode'], { [styles.selected]: this.props.mode === 'vector' })}>
                                     <Anchor
-                                        draggable="false"
                                         disabled={disabled}
                                         className={styles['laser-mode__btn']}
                                         onClick={() => actions.changeSelectedModelMode('vector')}
diff --git a/src/app/widgets/PrintingMaterial/Material.jsx b/src/app/widgets/PrintingMaterial/Material.jsx
index c4f5f34f5e..6540fe34a4 100644
--- a/src/app/widgets/PrintingMaterial/Material.jsx
+++ b/src/app/widgets/PrintingMaterial/Material.jsx
@@ -212,7 +212,6 @@ class Material extends PureComponent {
                             <Anchor
                                 key={option.value}
                                 className={classNames(styles['material-btn'], { [styles.selected]: this.actions.isMaterialSelected(option) })}
-                                draggable="false"
                                 onClick={() => this.actions.onChangeMaterial(option.value)}
                             >
                                 {i18n._(option.label)}
diff --git a/src/app/widgets/PrintingVisualizer/VisualizerCameraOperations.jsx b/src/app/widgets/PrintingVisualizer/VisualizerCameraOperations.jsx
index 0666d0d58a..00e38744fd 100644
--- a/src/app/widgets/PrintingVisualizer/VisualizerCameraOperations.jsx
+++ b/src/app/widgets/PrintingVisualizer/VisualizerCameraOperations.jsx
@@ -22,31 +22,26 @@ class VisualizerCameraOperations extends PureComponent {
             <React.Fragment>
                 <div style={{ display: 'inline-block', float: 'left' }}>
                     <Anchor
-                        draggable="false"
                         className={classNames('fa', 'fa-chevron-left', styles['turn-left'])}
                         onClick={actions.toLeft}
                     />
                 </div>
                 <div style={{ display: 'inline-block', float: 'left' }}>
                     <Anchor
-                        draggable="false"
                         className={classNames('fa', 'fa-chevron-up', styles['turn-up'])}
                         onClick={actions.toTop}
                     />
                     <Anchor
-                        draggable="false"
                         className={classNames(styles['camera-reset'])}
                         onClick={actions.autoFocus}
                     />
                     <Anchor
-                        draggable="false"
                         className={classNames('fa', 'fa-chevron-down', styles['turn-down'])}
                         onClick={actions.toBottom}
                     />
                 </div>
                 <div style={{ display: 'inline-block', float: 'left' }}>
                     <Anchor
-                        draggable="false"
                         className={classNames('fa', 'fa-chevron-right', styles['turn-right'])}
                         onClick={actions.toRight}
                     />