Provider demands tag optional property to be defined as [""]

[dlouseiro]

Provider Version

0.51.0

Terraform Version

v1.3.6

Describe the bug

When a snowflake_tag resource is created without allowed_values, the provider detects changes upon every terraform plan/apply, assuming that we're trying to change the value of allowed_values from [""] to null.

After some deeper investigation, I noticed that what is materialized in the terraform state when allowed_values is omitted is something like this:

"allowed_values": [
              ""
            ]

Although, when I run a SHOW TAGS, the allowed values are actually materialized as NULL when the allowed_values property is omitted, so if I run terraform apply multiple times, terraform always considers that the value for allowed_values is being changes from null to [""].

In order to ensure state consistency, I needed to force allowed_values = [""] in my terraform configuration.

Expected behavior

I'd expect the omission of an optional property to produce consistent states between what is in the state file and what is materialized in the database.

[bogdan-cioata]

Same here with 0.52, thanks reporting it!
allowed_values seems to be brought here: https://github.com/Snowflake-Labs/terraform-provider-snowflake/pull/1006/files#diff-38d5b48223911a8815b351930063d559dc5d182c2cef11bb9c262064f7787d3d

Also, seems that the resource attributes are weirdly ordered, not that it makes a difference:

+ resource "snowflake_tag" "xxx" {
      + allowed_values = [
          + "",
        ]
      + comment        = "comment"
      + database       = "database_name"
      + id             = (known after apply)
      + name           = "tag_tame"
      + schema         = "PUBLIC"
    }

vs.:

+ resource "snowflake_tag_association" "xxx" {
      + id              = (known after apply)
      + object_type     = "DATABASE"
      + skip_validation = true
      + tag_id          = (known after apply)
      + tag_value       = "tag_value"

      + object_identifier {
          + name = "database_name"
        }
    } 

[bogdan-cioata]

As a workaround, until the bug is fixed, you can use instead:

lifecycle {
    ignore_changes = [
      allowed_values
    ]
  }

[dlouseiro]

As a workaround, until the bug is fixed, you can use instead:

lifecycle {
ignore_changes = [
allowed_values
]
}

@bogdan-cioata

Won't this also ignore changes in allowed_values when there are "actual" changes, as in, when we actually change the allowed values of this tag?

[bogdan-cioata]

the workaround is for when you don't fill allowed_values.

[dlouseiro]

I just upgraded the provider to version 0.61 and it seems that this problem is now fixed.

[sfc-gh-asawicki]

Hey @dlouseiro, can we close the issue then?

[sfc-gh-jmichalak]

Hi @dlouseiro @bogdan-cioata 👋

This was already fixed in v0.61, but we've just released v0.99.0 (release, migration guide) in which we reworked tags. Please upgrade to this version and let us know if you have any issues.