Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowed_values in Tag - should be in order - it seems #1443

Open
cpmub1 opened this issue Dec 29, 2022 · 2 comments
Open

allowed_values in Tag - should be in order - it seems #1443

cpmub1 opened this issue Dec 29, 2022 · 2 comments
Labels
bug Used to mark issues with provider's incorrect behavior category:resource resource:tag Issue connected to the snowflake_tag resource

Comments

@cpmub1
Copy link

cpmub1 commented Dec 29, 2022

Snowflake is reordering the values from allowed_values list, irrespective of the sequence of values in the create/alter statement.
when the values are out of order in tf files, the plan/apply tries to change it in every run.

Hence, either comparison logic in terraform should change to order the allowed_values list values (or)
a note should be added to the documentation to provide the values in order.
@cpmub1 cpmub1 added the bug Used to mark issues with provider's incorrect behavior label Dec 29, 2022
@sfc-gh-jcieslak sfc-gh-jcieslak added category:resource resource:tag Issue connected to the snowflake_tag resource labels May 20, 2024
@sfc-gh-jmichalak sfc-gh-jmichalak mentioned this issue Nov 13, 2024
Merged
2 tasks
sfc-gh-jmichalak added a commit that referenced this issue Nov 20, 2024
@sfc-gh-jmichalak
feat: Tag resource v1 (#3197)
77b3bf0 
<!-- Feel free to delete comments as you fill this in -->
- rework tag resource for v1
- generate asserts and models
- deprecate snowflake_tag_masking_policy_association
- extract a parser for extracting schema object identifier list
<!-- summary of changes -->

## Test Plan
<!-- detail ways in which this PR has been tested or needs to be tested
-->
* [x] acceptance tests
<!-- add more below if you think they are relevant -->
* [ ] …

## References
<!-- issues documentation links, etc  -->
https://docs.snowflake.com/en/sql-reference/sql/create-tag

#1806

#1443

#1394

## TODO
- tag data source
- tag association resource
- asserting that ALTER MASKING POLICY [ IF EXISTS ] <name> SET TAG
doesn't alter the tag and vice-versa
- we already unset masking policies from the tags on the tag part, but
we're missing this on masking policies part - add acc tests, too
@sfc-gh-jmichalak
Copy link
Collaborator

Hi @cpmub1 👋

We've just released v0.99.0 (release, migration guide) in which we reworked tags. This issue should be fixed. Please upgrade to this version and let us know if you have any issues.

@cpmub1
Copy link
Author

cpmub1 commented Nov 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Used to mark issues with provider's incorrect behavior category:resource resource:tag Issue connected to the snowflake_tag resource
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cpmub1 @sfc-gh-jcieslak @sfc-gh-jmichalak