chore: Basic object tracking #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for 43ec04e4c1571f7163a9606c4d04240aa5216bef |
sfc-gh-asawicki
requested changes
Nov 18, 2024
|
Integration tests success for 19ed10a89f1543b36bf2a8eb5fd3ec98c2591b38 |
| return Metadata{}, fmt.Errorf("failed to parse metadata from sql, incorrect number of parts, expected: 2, got: %d", len(parts)) | ||
| } | ||
| var metadata Metadata | ||
| if err := json.Unmarshal([]byte(strings.TrimSpace(parts[1])), &metadata); err != nil { |
There was a problem hiding this comment.
Nit: I think that Unmarshal doesn't require the data to be trimmed.
There was a problem hiding this comment.
I would leave it just to be sure (I'm trimming the space after usage tracking prefix)
| log.Printf("[ERROR] failed to append metadata tracking: %v\n", err) | ||
| return sql | ||
| } | ||
| return newSql |
There was a problem hiding this comment.
Can we also log here if there's no metadata in the context?
There was a problem hiding this comment.
I'm wondering if that's necessary for now (could be added later) because it would log this message a lot
sfc-gh-asawicki
requested changes
Nov 20, 2024
# Conflicts: # pkg/provider/resources/resources.go
sfc-gh-asawicki
approved these changes
Nov 20, 2024
| @@ -277,7 +277,8 @@ func (c *Client) exec(ctx context.Context, sql string) (sql.Result, error) { | |||
| log.Printf("[DEBUG] sql-conn-exec-dry: %v\n", sql) | |||
| return nil, nil | |||
| } | |||
| ctx = context.WithValue(ctx, snowflakeAccountLocatorContextKey, c.accountLocator) | |||
| ctx = context.WithValue(ctx, SnowflakeAccountLocatorContextKey, c.accountLocator) | |||
There was a problem hiding this comment.
in follow also use struct{} here
There was a problem hiding this comment.
Addressed in #3214
sfc-gh-jmichalak
approved these changes
Nov 20, 2024
|
Integration tests failure for cdbf3fefd251c23dd451aa9e85a2298a80966db0 |
|
Integration tests failure for b53359f77b7aba9d2194b9bbda958420bc64566d |
sfc-gh-jcieslak
added a commit
that referenced
this pull request
Nov 25, 2024
follow up to #3205 ## Changes - applied comments from the previous pr (added test in resource and account locator key was changed to `struct{}`, etc.) - applied tracking wrappers to every resource that has implemented context method (in old ones we create context ourselves; I can go and add the context there too), also imports implemented as passthrough were skipped. - added missing resource names to `resource` type - added entry to our v1 guidelines to add wrapper around terraform functions - modified test client for information schema a bit ## Coming up - data sources (after pr that adds data source names similar to the `resrouces.Resource` interface)
sfc-gh-jmichalak
pushed a commit
that referenced
this pull request
Nov 26, 2024
🤖 I have created a release *beep* *boop* --- ## [0.99.0](v0.98.0...v0.99.0) (2024-11-26) ### 🎉 **What's new:** * Add tags data source ([#3211](#3211)) ([8907d9d](8907d9d)) * Tag resource v1 ([#3197](#3197)) ([77b3bf0](77b3bf0)) * Tasks v1 readiness ([#3222](#3222)) ([e2284d9](e2284d9)) ### 🔧 **Misc** * Add support for usage tracking to data sources ([#3224](#3224)) ([8210bb8](8210bb8)) * Add usage tracking for the rest of the resources and fix views ([#3223](#3223)) ([231f653](231f653)) * Basic object tracking ([#3205](#3205)) ([1f0dc94](1f0dc94)) * basic object tracking part 2 ([#3214](#3214)) ([e44f2e1](e44f2e1)) * Improve tags integration tests ([#3193](#3193)) ([7736e0a](7736e0a)) * parser and secret tests ([#3192](#3192)) ([5ec9c86](5ec9c86)) * Storage integration with custom protocol ([#3213](#3213)) ([a3a44ae](a3a44ae)) * Unskip auth config tests ([#3180](#3180)) ([46ab142](46ab142)) ### 🐛 **Bug fixes:** * Small fixes and adjustments ([#3226](#3226)) ([9f67457](9f67457)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Next pr