Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Warehouse redesign part2 #2887

Merged
merged 32 commits into from
Jun 27, 2024
Merged

feat: Warehouse redesign part2 #2887

merged 32 commits into from
Jun 27, 2024

Conversation

sfc-gh-asawicki
Copy link
Collaborator

@sfc-gh-asawicki sfc-gh-asawicki commented Jun 24, 2024

Warehouses redesign part2 (continuation of #2864):

  • state upgraders for all cases (with acceptance tests)
  • TODOs in acceptance and integration tests solved
  • suspending the resource on the SDK level
  • change resource monitor type in the SDK
  • add missing UNSET tests
  • handle not working UNSETs with proper SETs
  • migration guide updated

Other changes:

  • Use Name() for account object identifiers in show output

Still missing (next PR):

  • datasource

Note:

  • parts of the logic may be still changed after our internal discussions; it may affect migration guide and the resource behavior

Copy link

Integration tests failure for 389177ed3f440c1ab2246b67fb215d0eafa06522

Copy link

Integration tests failure for 376002b78f4c49460f8d40d225a76e44053a79dd

@sfc-gh-asawicki sfc-gh-asawicki marked this pull request as ready for review June 25, 2024 10:17
Copy link

Integration tests failure for 376002b78f4c49460f8d40d225a76e44053a79dd

pkg/sdk/warehouses.go Outdated Show resolved Hide resolved
pkg/sdk/warehouses.go Show resolved Hide resolved
pkg/resources/warehouse_acceptance_test.go Show resolved Hide resolved
Copy link

Integration tests failure for 7e49dc03d51b41b80e0f9ed40b5d691086353065

pkg/resources/warehouse.go Show resolved Hide resolved
pkg/resources/warehouse.go Show resolved Hide resolved
pkg/resources/warehouse.go Show resolved Hide resolved
Copy link

Integration tests failure for f10d6688c8f5f6f40c0881ab76920929312d2994

Copy link

Integration tests failure for 2e6ee5e3c5f96288d75b1170a275a3eea8eca890

@sfc-gh-asawicki sfc-gh-asawicki merged commit 1aaf417 into main Jun 27, 2024
9 of 10 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the warehouse-redesign-part2 branch June 27, 2024 08:17
sfc-gh-asawicki added a commit that referenced this pull request Jun 27, 2024
Warehouses redesign part2 (continuation of
#2887):
- add datasource
- handle error for show warehouse

Still missing (next PR):
- encapsulate 3-value boolean logic
- extract and generalize part of read logic
sfc-gh-jcieslak pushed a commit that referenced this pull request Jul 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.93.0](v0.92.0...v0.93.0)
(2024-07-10)


### 🎉 **What's new:**

* Add OAUTH integration for custom clients
([#2908](#2908))
([d9b557f](d9b557f))
* Add oauth integration for partner applications
([#2912](#2912))
([91788e5](91788e5))
* Add support for cortex search service
([#2860](#2860))
([43aa89f](43aa89f))
* API Authentication integration v1 readiness
([#2898](#2898))
([91931da](91931da))
* External Oauth integration v1 readiness
([#2907](#2907))
([ed237c3](ed237c3))
* Generate show outputs with mappers
([#2886](#2886))
([1cada88](1cada88))
* Introduce security integrations datasource
([#2892](#2892))
([7f6c657](7f6c657))
* SAML2 integration v1 readiness
([#2868](#2868))
([d0c136d](d0c136d))
* SCIM integration v1 readiness
([#2846](#2846))
([269df6b](269df6b))
* Security integrations datasource v1 readiness
([#2913](#2913))
([d10474a](d10474a))
* standard database v1 readiness
([#2842](#2842))
([3c11953](3c11953))
* Warehouse redesign final touches
([#2900](#2900))
([0eab636](0eab636))
* Warehouse redesign part1
([#2864](#2864))
([6664457](6664457))
* Warehouse redesign part2
([#2887](#2887))
([1aaf417](1aaf417))
* Warehouse redesign part3
([#2890](#2890))
([873a1ed](873a1ed))
* Warehouse redesign part4
([#2893](#2893))
([d525fd9](d525fd9))


### 🔧 **Misc**

* Add documentation on unset and defaults
([#2882](#2882))
([85a7836](85a7836))
* apply minor database changes
([#2872](#2872))
([6ccac59](6ccac59))
* Apply new resource conventions to scim integration
([#2891](#2891))
([e11e608](e11e608))
* Improve generator template organization
([#2820](#2820))
([5035e2f](5035e2f))
* Nuke stale objects
([#2869](#2869))
([9c4a117](9c4a117))
* Show a possible solution for
[#2877](https://github.com/Snowflake-Labs/terraform-provider-snowflake/issues/2877)
([#2878](#2878))
([6fb437b](6fb437b))
* Validations cleanup and old grants removal
([#2884](#2884))
([05b7eee](05b7eee))


### 🐛 **Bug fixes:**

* Add disclaimers and fix tests
([#2905](#2905))
([1deaedc](1deaedc))
* Fix cortex search service
([#2904](#2904))
([763d06c](763d06c))
* use suppressQuoting to fix stage file_format permadiff
([#2885](#2885))
([fd70f6e](fd70f6e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants