chore: basic object tracking part 2 #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for efd7e03299256666a9e107cc91c8da75466d039e |
sfc-gh-asawicki
requested changes
Nov 21, 2024
sfc-gh-jmichalak
requested changes
Nov 22, 2024
| } | ||
|
|
||
| func (c *InformationSchemaClient) GetQueryTagByQueryId(t *testing.T, queryId string) string { | ||
| func (c *InformationSchemaClient) GetQueryHistoryByQueryId(t *testing.T, limit int, queryId string) QueryHistory { |
There was a problem hiding this comment.
I think we can agree on a default limit here and avoid specifying it in each call.
There was a problem hiding this comment.
I would leave it as a value to specify as I changed this a lot during testing and we should aim for as little number as possible
|
Integration tests failure for 5bc77fce87f42a4b98cb46142574b74ebf43c313 |
sfc-gh-jmichalak
previously approved these changes
Nov 22, 2024
Comment on lines
+43
to
+48
| if metadata, err := tracking.ParseMetadata(history.QueryText); err == nil { | ||
| if expectedMetadata == metadata && strings.Contains(history.QueryText, query) { | ||
| return true | ||
| } | ||
| } | ||
| return false |
There was a problem hiding this comment.
Nit:
Suggested change
| if metadata, err := tracking.ParseMetadata(history.QueryText); err == nil { | |
| if expectedMetadata == metadata && strings.Contains(history.QueryText, query) { | |
| return true | |
| } | |
| } | |
| return false | |
| metadata, err := tracking.ParseMetadata(history.QueryText) | |
| return err == nil && | |
| expectedMetadata == metadata && | |
| strings.Contains(history.QueryText, query) |
sfc-gh-asawicki
previously approved these changes
Nov 24, 2024
sfc-gh-jcieslak
dismissed stale reviews from sfc-gh-asawicki and sfc-gh-jmichalak
via
ab0095a
|
Integration tests cancelled for ab0095a4a28b16ae49560ef7c86865a3c0d7e1ff |
sfc-gh-jmichalak
approved these changes
Nov 25, 2024
sfc-gh-jmichalak
pushed a commit
that referenced
this pull request
Nov 26, 2024
🤖 I have created a release *beep* *boop* --- ## [0.99.0](v0.98.0...v0.99.0) (2024-11-26) ### 🎉 **What's new:** * Add tags data source ([#3211](#3211)) ([8907d9d](8907d9d)) * Tag resource v1 ([#3197](#3197)) ([77b3bf0](77b3bf0)) * Tasks v1 readiness ([#3222](#3222)) ([e2284d9](e2284d9)) ### 🔧 **Misc** * Add support for usage tracking to data sources ([#3224](#3224)) ([8210bb8](8210bb8)) * Add usage tracking for the rest of the resources and fix views ([#3223](#3223)) ([231f653](231f653)) * Basic object tracking ([#3205](#3205)) ([1f0dc94](1f0dc94)) * basic object tracking part 2 ([#3214](#3214)) ([e44f2e1](e44f2e1)) * Improve tags integration tests ([#3193](#3193)) ([7736e0a](7736e0a)) * parser and secret tests ([#3192](#3192)) ([5ec9c86](5ec9c86)) * Storage integration with custom protocol ([#3213](#3213)) ([a3a44ae](a3a44ae)) * Unskip auth config tests ([#3180](#3180)) ([46ab142](46ab142)) ### 🐛 **Bug fixes:** * Small fixes and adjustments ([#3226](#3226)) ([9f67457](9f67457)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #3205
Changes
struct{}, etc.)resourcetypeComing up
resrouces.Resourceinterface)