Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide abstractions for public API #5

Open
Matthiee opened this issue May 3, 2021 · 3 comments
Open

Provide abstractions for public API #5

Matthiee opened this issue May 3, 2021 · 3 comments

Comments

@Matthiee
Copy link

Matthiee commented May 3, 2021

It would be nice to have an abstraction layer so that consumers of this library can mock out instances of the library in unit tests!

@chyyran
Copy link
Member

chyyran commented May 3, 2021

Hi,

Not sure what you mean an abstraction layer, what type of meaningful abstractions would you like to see?

@Matthiee
Copy link
Author

Matthiee commented May 3, 2021

Hi

I mean something like this:

public interface IVcEncoder : IDisposable
{
    VCDiffResult Encode();
    Task<VCDiffResult> EncodeAsync();
}

@chyyran
Copy link
Member

chyyran commented May 3, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants