Skip to content
This repository has been archived by the owner on Feb 10, 2023. It is now read-only.

[BUG] Live session check #147

Closed
reacap opened this issue May 7, 2021 · 3 comments
Closed

[BUG] Live session check #147

reacap opened this issue May 7, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@reacap
Copy link

reacap commented May 7, 2021

Please check the FAQ and search existing issues before you submit a new one!

Describe the bug
Version 2.0.1 not checking for live sessions while live session is played ( opened in mpv)

To Reproduce
Steps to reproduce the behavior:

  1. 2.0.1 version
  2. Try to play live session
  3. Live sessions check stop working

Expected behaviour
Live session check should be working . At least I think that was the case with old versions

Screenshots
https://i.imgur.com/uUioDYW.png

F1TV account plan
F1 tv pro / no vpn

Desktop (please complete the following information):

  • Win10
  • Github Download
  • Version 2.0.1

Logs
Last logs entries

2021/05/07 10:12:34 [INFO] logged in!
2021/05/07 10:12:34 [INFO] checking for live session
2021/05/07 10:12:37 [INFO] checking for multi commands

After the start of fp1 session live check stopped working . Same issue last weekend with overlapping sessions like pre race show and race later . Had to restart the app for it to work

@reacap reacap added the bug Something isn't working label May 7, 2021
@Arnvidr
Copy link

Arnvidr commented Oct 24, 2021

Seeing the same bug on self-built 2.3.0 on linux.

edit:
I assume this could be fixed by removing the return in the isLive switch branch in 'internal/ui/live.go', might try that next race weekend.

@SoMuchForSubtlety
Copy link
Owner

edit: I assume this could be fixed by removing the return in the isLive switch branch in 'internal/ui/live.go', might try that next race weekend.

Correct, but we would ideally also remove the old live session as soon as it's no longer live. You can try to implement the change, or If you don't feel up to it, I can do it too.

@Arnvidr
Copy link

Arnvidr commented Oct 26, 2021

I've never done any go programming, so I'm not sure I should be messing with it, but shouldn't the same change make it be removed on the next iteration after end of the live session? I'm confused by the whole channel/receiver bit of the go syntax, so I'm not sure what would actually happen here. Does it ever get removed in the version available now?

SoMuchForSubtlety added a commit that referenced this issue Oct 26, 2021
 * keep checking for new live sessions
 * remove sessions that are no longer live

 closes  #147
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants