-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can 18 #7
Can 18 #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nice to have is adding more metadata to the toml (see comment). Otherwise, LGTM!
license = "MIT" | ||
readme = "README.md" | ||
include = [ | ||
{ path = "canopy/data/lift.zip" }, | ||
{ path = "somadata/data/lift.zip" }, | ||
{ path = "*.adat" } | ||
] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking it may also be helpful to include some additional metadata like "classifiers", "homepage", and "repository".
classifiers = [
"Development Status :: 5 - Production/Stable",
"Intended Audience :: Science/Research",
"Operating System :: OS Independent",
"Topic :: Scientific/Engineering",
]
homepage = "https://www.standardbio.com/"
repository = "https://github.com/SomaLogic/Canopy"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feedback! I have added this metadata.
I'm changing the name so that we can make this a PyPI package named SomaData. Changing the name is a breaking change so I am updating the version to 1.0.0.