Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can 18 #7

Merged
merged 5 commits into from
May 15, 2024
Merged

Can 18 #7

merged 5 commits into from
May 15, 2024

Conversation

tjohnson-somalogic
Copy link
Contributor

I'm changing the name so that we can make this a PyPI package named SomaData. Changing the name is a breaking change so I am updating the version to 1.0.0.

@tjohnson-somalogic tjohnson-somalogic self-assigned this May 14, 2024
@tjohnson-somalogic tjohnson-somalogic linked an issue May 14, 2024 that may be closed by this pull request
Copy link
Contributor

@kyoung73 kyoung73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nice to have is adding more metadata to the toml (see comment). Otherwise, LGTM!

license = "MIT"
readme = "README.md"
include = [
{ path = "canopy/data/lift.zip" },
{ path = "somadata/data/lift.zip" },
{ path = "*.adat" }
]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking it may also be helpful to include some additional metadata like "classifiers", "homepage", and "repository".

classifiers = [
    "Development Status :: 5 - Production/Stable",
    "Intended Audience :: Science/Research",
    "Operating System :: OS Independent",
    "Topic :: Scientific/Engineering",
]
homepage = "https://www.standardbio.com/"
repository = "https://github.com/SomaLogic/Canopy"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feedback! I have added this metadata.

@tjohnson-somalogic tjohnson-somalogic merged commit d91253f into master May 15, 2024
2 checks passed
@kyoung73 kyoung73 deleted the CAN-18 branch November 13, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a pypi package
2 participants