Fix index out of range error in convertLine #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneSutro
requested changes
Jul 22, 2021
There was a problem hiding this comment.
@natekspencer - This looks great! Nice catch in just swapping around the logic.
One final note - please add corresponding tests inside tests/test_formatting.py to cover the changes. Once those are added, I will merge!
|
@natekspencer - you can just follow the same format as the existing tests. If you've never use Pytest before, just make sure the function name you choose starts with the word |
|
There you go! |
|
Looks great!! Really nice work. Thanks for the collaboration, @natekspencer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for https://github.com/SonicRift/Vestaboard/issues/17