🌱 update build workflow #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kranurag7
commented
May 24, 2024
kranurag7
commented
we had a check for build but that was triggering when we merged a PR on main branch and I don't think that's useful. We still had failures even after that check. This commits adds the same check to pr-lint workflow and removes the build workflow that runs when a PR gets merged into main branch. The reason to run it as part of lint workflow was because we have go installed as part of this workflow. We now also run it before we lint the codebase, this makes sure that we run the build first followed by linting the codebase. Signed-off-by: kranurag7 <anurag.kumar@syself.com>
janiskemper
approved these changes
May 24, 2024
Member
janiskemper
left a comment
janiskemper
left a comment
There was a problem hiding this comment.
let's see whether it solves its purpose ;)
Member
|
works haha |
Contributor
Author
|
I think it works, I'll proceed with merging this and solve linting issue in a separate patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.