✨ Restructure code to have better readability #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniruddha2000
changed the title
aniruddha2000
force-pushed
the
ani-syself/issues/37
branch
from
44ae4c2 to
6b851da
Compare
aniruddha2000
changed the title
aniruddha2000
force-pushed
the
ani-syself/issues/37
branch
from
6b851da to
0c2804d
Compare
Contributor
|
@aniruddha2000 the heading of the PR does not fit to the content. The PR adds the new content based hasing. Please add this to the title and the description. |
aniruddha2000
changed the title
Member
Author
|
done |
aniruddha2000
force-pushed
the
ani-syself/issues/37
branch
from
0c2804d to
f7f5548
Compare
Member
Author
|
@guettli please review it again, I've removed the git hash and clusterstack hash from this PR and will add a follow up PR after this |
aniruddha2000
changed the title
aniruddha2000
force-pushed
the
ani-syself/issues/37
branch
from
f7f5548 to
54dd733
Compare
aniruddha2000
requested review from
janiskemper
and removed request for
janiskemper
janiskemper
approved these changes
Jan 29, 2024
Member
janiskemper
left a comment
janiskemper
left a comment
There was a problem hiding this comment.
approving this to not block further PRs. If bugs exist, we can fix them later before we release
Signed-off-by: Aniruddha Basak <aniruddha.basak@syself.com>
aniruddha2000
force-pushed
the
ani-syself/issues/37
branch
from
54dd733 to
6a52bac
Compare
jschoone
added
the
Container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #37
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: