-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] ImGuizmo #54
[API] ImGuizmo #54
Conversation
Hi. Good work! Appreciate the example introduction.
That all creates 65k lines diff and I don't know where to look for real changes. Also, please, check the original PR. I made a small review of it, but I see the same probs here as well. GIF with example looks good. |
I've updated the example, deleted the unnecessary build files and fixed crashes. One thing that I want to note here, is that I am not gonna implement any other features such as ImSequencer etc. I've added comments for you to look and give feedback (in the example file: ExampleImGuizmo.java (row: 262)) PS: Please build the other dll files for yourself. I've only built imgui-java64 since I am running 64 bit Windows. Thanks |
Apparently, the build for java 8 crashed because I've been using the fancier way of doing switch statements. |
I'll do a detail review a bit later (maybe on a weekend). What I can see from now is that you don't need to provide Updated example looks super cool! It's a great addition to the library for sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, as I said, please remove bin/
folder.
imgui-binding/src/main/java/imgui/extension/imguizmo/ImGuizmo.java
Outdated
Show resolved
Hide resolved
imgui-binding/src/main/java/imgui/extension/imguizmo/ImGuizmo.java
Outdated
Show resolved
Hide resolved
imgui-binding/src/main/java/imgui/extension/imguizmo/ImGuizmo.java
Outdated
Show resolved
Hide resolved
imgui-binding/src/main/java/imgui/extension/imguizmo/ImGuizmo.java
Outdated
Show resolved
Hide resolved
imgui-binding/src/main/java/imgui/extension/imguizmo/ImGuizmo.java
Outdated
Show resolved
Hide resolved
I've did more and included pretty much doc for all the necessary methods. It looks professional now and awaits for your approval. |
The check failed because there's a unused import in the ImGuizmo class but ImGuizmo class uses the import for the comment. See Other than that, everything checks out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By removing the bin folder I meant to remove it from your diff, not to delete completle. Just revert all changes to the dir.
The check failed because there's a unused import in the ImGuizmo class but ImGuizmo class uses the import for the comment.
Just do the import in the javadoc itself. Like: {@link imgui.extension.imguizmo.flag.Operation#ROTATE}
I've reverted all changes to the |
For your info, I'll merge the PR on the weekend. Dear ImGui also had released 1.83, so I'll do everything in one go. If you have something to polish - there is time to do that. |
I see that you force pushed your own commits in to my master branch. Can I get the reason why you are doing this, since force pushing can produce a lot of mayhem. Additionally, my commits are "deleted" since you force pushed it. |
I prepared the PR for the merge. Your commits are not "deleted", but squashed. I would do it anyway during the merge itself. Force push doesn't produce a mayhem, it's a normal practice to squash a bunch of commits into one, since it's an atomic change. |
This PR finalizes #41 and adds ImGuizmo.
I've already added an example for you to try. There are random weird crashes with the snapping feature and there's still a lot to add, so do not merge it yet.
I am gonna let you know, after I've fixed the crashes and added more features, so that you can go ahead and merge it.
Please have a quick look at the code and let me know if I have any errors/type styles to fix.
Example:
ImGuizmo-Example-java.mp4