Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lwjgl from 3.2.3 to 3.3.0 #96

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Update lwjgl from 3.2.3 to 3.3.0 #96

merged 1 commit into from
Dec 15, 2021

Conversation

Illithidek
Copy link
Contributor

@Illithidek Illithidek commented Dec 8, 2021

Update lwjgl from 3.2.3 to 3.3.0
In order to use imgui-java with the lwjgl 3.3.0 without errors there is need for an update.
To remove code duplication when changing dependencies,
an lwjgl.bom variable was added.
Fixes: #95

  • update lwjgl version from 3.2.3 to 3.3.0 across all submodules

@tlf30
Copy link
Contributor

tlf30 commented Dec 9, 2021

It would be handy if there was a common lwjglVersion variable in the root build.gradle that was used instead of hard coding the version in multiple places.

@Illithidek
Copy link
Contributor Author

I can change it but tommorow :)!

@SpaiR SpaiR added the feat New feature or request label Dec 10, 2021
@Illithidek
Copy link
Contributor Author

@SpaiR @tlf30 Bump, I added dependencies.gradle which could have similar variables in the future :)

@SpaiR
Copy link
Owner

SpaiR commented Dec 13, 2021

@Illithidek Hi! I've went through the PR and for me it seems a little bit over designed. I would likely prefer something more straightforward. For example, declare an ext block in the root build.gradle file and to define all deps there. Without hiding dependencies under custom props and additional buildscripts. Only handling of the common versioning. I know that it's a point to consider and a matter of taste. Thus, if you don't want to go with another solution, this is fine to revert the PR to the initial commit. Going only with an lwjgl update will be totally ok.

In order to use imgui-java with the lwjgl 3.3.0 without errors there is need for an update.
To remove code duplication when changing dependencies,
an lwjgl.bom variable was added.
Fixes: SpaiR#95

- update lwjgl version from 3.2.3 to 3.3.0 across all submodules
@Illithidek
Copy link
Contributor Author

@SpaiR That was a mechanism that I use in other projects, but if you want it simpler, then I've just simplified it for you :).
Let me know if you have any other feedback!

@SpaiR SpaiR merged commit 823dd6f into SpaiR:master Dec 15, 2021
SpaiR pushed a commit that referenced this pull request Dec 15, 2021
In order to use imgui-java with the lwjgl 3.3.0 without errors there is need for an update.
To remove code duplication when changing dependencies,
an lwjgl.bom variable was added.
Fixes: #95

- update lwjgl version from 3.2.3 to 3.3.0 across all submodules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnsatisfiedLinkError when upgrade imgui-java from 1.83.2 to 1.85.0
3 participants