Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/mdoc-parsing #185

Merged
merged 19 commits into from
Nov 1, 2024
Merged

feature/mdoc-parsing #185

merged 19 commits into from
Nov 1, 2024

Conversation

sanderPostma
Copy link
Contributor

@sanderPostma sanderPostma commented Oct 31, 2024

This was a pre-merge from Animo which is now approved

TimoGlastra and others added 14 commits October 31, 2024 00:23
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
feat: mdoc selectFrom, evaluation and parsing
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
fix: support generating submission for mdoc
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 69.76744% with 13 lines in your changes missing coverage. Please review.

Project coverage is 92.69%. Comparing base (772a058) to head (4cabdd3).
Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
lib/evaluation/evaluationClientWrapper.ts 63.63% 12 Missing ⚠️
...ation/handlers/limitDisclosureEvaluationHandler.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #185      +/-   ##
===========================================
- Coverage    92.81%   92.69%   -0.13%     
===========================================
  Files           66       66              
  Lines         2728     2750      +22     
  Branches       711      722      +11     
===========================================
+ Hits          2532     2549      +17     
- Misses         190      196       +6     
+ Partials         6        5       -1     
Flag Coverage Δ
unittest 92.69% <69.76%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TimoGlastra and others added 5 commits November 1, 2024 16:58
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
feat: support multi-document mdoc device response
@sanderPostma sanderPostma merged commit 9596f9d into develop Nov 1, 2024
2 of 4 checks passed
@sanderPostma sanderPostma deleted the feature/mdoc-parsing branch November 1, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants