From acb5935b327fb2678bf5bfa5cc1eab31f251dccd Mon Sep 17 00:00:00 2001 From: zm711 <92116279+zm711@users.noreply.github.com> Date: Sun, 9 Mar 2025 16:29:09 -0400 Subject: [PATCH 1/5] test a ruff action --- .github/workflows/ruff.yml | 19 +++++++++++++++++++ pyproject.toml | 5 +++++ 2 files changed, 24 insertions(+) create mode 100644 .github/workflows/ruff.yml diff --git a/.github/workflows/ruff.yml b/.github/workflows/ruff.yml new file mode 100644 index 0000000000..23e3567fed --- /dev/null +++ b/.github/workflows/ruff.yml @@ -0,0 +1,19 @@ +name: Ruff Linting + +on: + pull_request: + types: [synchronize, opened, reopened] + branches: + - main + +concurrency: # Cancel previous workflows on the same pull request + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + +jobs: + ruff-linting: + name: Ruff Linting + strategy: + fail-fast: false + steps: + - uses: astral-sh/ruff-action@v3 diff --git a/pyproject.toml b/pyproject.toml index 97ba77299e..808403b113 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -50,6 +50,11 @@ exclude = ["spikeinterface.*.tests"] [tool.black] line-length = 120 +[tool.ruff] +line-length = 120 +[tool.ruff.lint] +select = ['F401'] + [project.urls] homepage = "https://github.com/SpikeInterface/spikeinterface" repository = "https://github.com/SpikeInterface/spikeinterface" From f5154cb91390552c026f5a9f6bffed7297ca4e7c Mon Sep 17 00:00:00 2001 From: zm711 <92116279+zm711@users.noreply.github.com> Date: Sun, 9 Mar 2025 16:33:18 -0400 Subject: [PATCH 2/5] oops --- .github/workflows/ruff.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ruff.yml b/.github/workflows/ruff.yml index 23e3567fed..d02e24ef29 100644 --- a/.github/workflows/ruff.yml +++ b/.github/workflows/ruff.yml @@ -11,7 +11,7 @@ concurrency: # Cancel previous workflows on the same pull request cancel-in-progress: true jobs: - ruff-linting: + run: name: Ruff Linting strategy: fail-fast: false From 5ed3ddc17ddb6163621270d0391031b627216014 Mon Sep 17 00:00:00 2001 From: zm711 <92116279+zm711@users.noreply.github.com> Date: Sun, 9 Mar 2025 16:37:24 -0400 Subject: [PATCH 3/5] add ruff check --- .github/workflows/ruff.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ruff.yml b/.github/workflows/ruff.yml index d02e24ef29..2dad88e493 100644 --- a/.github/workflows/ruff.yml +++ b/.github/workflows/ruff.yml @@ -17,3 +17,4 @@ jobs: fail-fast: false steps: - uses: astral-sh/ruff-action@v3 + - run: ruff check From 0e61521779f10871fbf66f2fe31bb8eae8fcadc9 Mon Sep 17 00:00:00 2001 From: zm711 <92116279+zm711@users.noreply.github.com> Date: Sun, 9 Mar 2025 16:43:19 -0400 Subject: [PATCH 4/5] another try --- .github/workflows/ruff.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ruff.yml b/.github/workflows/ruff.yml index 2dad88e493..0860cd8fc9 100644 --- a/.github/workflows/ruff.yml +++ b/.github/workflows/ruff.yml @@ -13,8 +13,11 @@ concurrency: # Cancel previous workflows on the same pull request jobs: run: name: Ruff Linting + runs-on: ubuntu-latest strategy: fail-fast: false steps: + - uses: actions/checkout@v4 - uses: astral-sh/ruff-action@v3 - - run: ruff check + with: + args: check From b8dde0550a382c4995a43e6099e9a672cd46afa8 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 5 Sep 2025 14:11:16 +0000 Subject: [PATCH 5/5] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- src/spikeinterface/extractors/phykilosortextractors.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spikeinterface/extractors/phykilosortextractors.py b/src/spikeinterface/extractors/phykilosortextractors.py index 8209d93543..46a8e4cecb 100644 --- a/src/spikeinterface/extractors/phykilosortextractors.py +++ b/src/spikeinterface/extractors/phykilosortextractors.py @@ -40,7 +40,7 @@ class BasePhyKilosortSortingExtractor(BaseSorting): The cluster_id column is used as the merge key to combine properties from multiple files. All loaded properties are added to the sorting extractor as unit properties, with some renamed for SpikeInterface conventions: 'group' becomes 'quality', 'cluster_id' - becomes 'original_cluster_id'. These properties can be accessed via ``sorting.get_property()`` + becomes 'original_cluster_id'. These properties can be accessed via ``sorting.get_property()`` function. """