Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider a less generic name or path for the versions file #725

Open
Vampire opened this issue Sep 10, 2024 · 2 comments
Open

Please consider a less generic name or path for the versions file #725

Vampire opened this issue Sep 10, 2024 · 2 comments

Comments

@Vampire
Copy link
Contributor

Vampire commented Sep 10, 2024

I have this plugin and https://github.com/SonarSource/sonar-scanner-gradle in the same classpath.
Both plugins have the very generic /version.txt file in their JAR and read it to find out their own version.
This of course makes one of the plugins misidentify its version, in my case the SonarQube plugin thinks it is version 0.60.3 because this plugin comes first in the classpath.

It would be better to have a more unique name like refreshVersions-version.txt or the file moved to a path under the namespace of this plugin like de/fayard/refreshVersions/core/version.txt to minimize the risk of resource-name-clash with other plugins or libraries.

@Vampire
Copy link
Contributor Author

Vampire commented Sep 12, 2024

I'm not talking about the file where the versions are stored.
I'm talking about the version.txt file that is included in the plugin jar that contains the plugin's version.

@jschneider
Copy link

Sorry! Too tired his morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants