✨ Fix version catalog writing #724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some fonts, the arrow symbol was only 1 character wide instead of 2. Using a classic character negates this issue
The sections are now ordered as described in the gradle documentation: https://docs.gradle.org/current/userguide/platforms.html#sub::toml-dependencies-format
MaxMichel2
changed the title
|
FYI, the check has failed due to some signing configuration that doesn't seem to work (This hasn't been modified so I suspect the issue lies on your side since I have no way of handling this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello/bonjour,
What?
Resolves #705
Why?
Fixes the issues with version alignment in the version catalog which was dependent on the font used in the IDE. The symbol used is now font-agnostic and is always the same size.
This PR also fixes the somewhat annoying issue where the sections of the version catalog were re-ordered. The order now follows what most people will expect and also what is described in the Gradle documentation (See here).
How?
⬆symbol with the^character[versions][libraries][bundles][plugins]Testing?
Published to mavenLocal and tested in a local project using refreshVersions