Fixed assert form error

SpongePowered · Dec 30, 2023 · 20963d9 · 20963d9
1 parent 770f5b0
commit 20963d9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/spongeauth/accounts/tests/test_view_login.py b/spongeauth/accounts/tests/test_view_login.py
@@ -49,15 +49,15 @@ def test_constructs_authentication_form(self):
     def test_errors_with_invalid_username(self):
         resp = self.client.post(self.path(), {"username": "foobar", "password": "barbarbar"})
         assert isinstance(resp.context["form"], forms.AuthenticationForm)
-        self.assertFormError(resp, "form", "username", "There is no user with that username.")
+        self.assertFormError(resp.context["form"], "username", "There is no user with that username.")
         user = django.contrib.auth.get_user(self.client)
         assert not user.is_authenticated
 
     def test_errors_with_invalid_password(self):
         user = factories.UserFactory.create()
         resp = self.client.post(self.path(), {"username": user.username, "password": "barbarbar"})
         assert isinstance(resp.context["form"], forms.AuthenticationForm)
-        self.assertFormError(resp, "form", "password", "The provided password was incorrect.")
+        self.assertFormError(resp.context["form"], "password", "The provided password was incorrect.")
         user = django.contrib.auth.get_user(self.client)
         assert not user.is_authenticated
 

diff --git a/spongeauth/twofa/tests/test_view_helpers.py b/spongeauth/twofa/tests/test_view_helpers.py
@@ -44,7 +44,7 @@ def test_has_paper_codes(self):
 
 @pytest.mark.django_db
 class TestGeneratePaperCodesIfNeeded:
-    def setup(self):
+    def setup_method(self):
         self.user = accounts.models.User(twofa_enabled=True)
         self.user.save()
 

diff --git a/spongeauth/twofa/tests/test_view_setup_totp.py b/spongeauth/twofa/tests/test_view_setup_totp.py
@@ -34,7 +34,7 @@ def extract_secret(self, resp, user=None):
         return base64.b32decode(setup_signer.unsign(resp.context[-1]["form"].secret))
 
     def signer(self, user):
-        return django.core.signing.TimestampSigner("twofa.views.setup_totp:{}".format(user.pk))
+        return django.core.signing.TimestampSigner(key="twofa.views.setup_totp:{}".format(user.pk))
 
     def test_requires_login(self):
         client = django.test.Client()

diff --git a/spongeauth/twofa/views.py b/spongeauth/twofa/views.py
@@ -109,7 +109,7 @@ def setup_totp(request):
         messages.error(request, _("You may not have multiple Google Authenticators attached to your account."))
         return redirect("twofa:list")
 
-    setup_signer = TimestampSigner("twofa.views.setup_totp:{}".format(request.user.pk))
+    setup_signer = TimestampSigner(key="twofa.views.setup_totp:{}".format(request.user.pk))
 
     if request.method == "POST" and "secret" in request.POST:
         try: